From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Keyur Patel <iamkeyur96@gmail.com>
Cc: allison.henderson@oracle.com, bfoster@redhat.com,
chandanrlinux@gmail.com, dchinner@redhat.com,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: Couple of typo fixes in comments
Date: Mon, 22 Jun 2020 10:29:12 -0700 [thread overview]
Message-ID: <20200622172912.GI11245@magnolia> (raw)
In-Reply-To: <20200607074459.98284-1-iamkeyur96@gmail.com>
On Sun, Jun 07, 2020 at 03:44:59AM -0400, Keyur Patel wrote:
> ./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary
> ./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour
> ./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
Looks simple enough, though I bet this will have to be rebased against
5.8...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index 6f84ea85fdd8..5c93e8e6de74 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -53,10 +53,10 @@ xfs_inobp_check(
> * If the readahead buffer is invalid, we need to mark it with an error and
> * clear the DONE status of the buffer so that a followup read will re-read it
> * from disk. We don't report the error otherwise to avoid warnings during log
> - * recovery and we don't get unnecssary panics on debug kernels. We use EIO here
> + * recovery and we don't get unnecessary panics on debug kernels. We use EIO here
> * because all we want to do is say readahead failed; there is no-one to report
> * the error to, so this will distinguish it from a non-ra verifier failure.
> - * Changes to this readahead error behavour also need to be reflected in
> + * Changes to this readahead error behaviour also need to be reflected in
> * xfs_dquot_buf_readahead_verify().
> */
> static void
> @@ -203,7 +203,7 @@ xfs_inode_from_disk(
> /*
> * First get the permanent information that is needed to allocate an
> * inode. If the inode is unused, mode is zero and we shouldn't mess
> - * with the unitialized part of it.
> + * with the uninitialized part of it.
> */
> to->di_flushiter = be16_to_cpu(from->di_flushiter);
> inode->i_generation = be32_to_cpu(from->di_gen);
> --
> 2.26.2
>
prev parent reply other threads:[~2020-06-22 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 7:39 [PATCH 2/2] xfs: Couple of typo fixes in comments Keyur Patel
2020-06-07 7:44 ` [PATCH] " Keyur Patel
2020-06-22 17:29 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622172912.GI11245@magnolia \
--to=darrick.wong@oracle.com \
--cc=allison.henderson@oracle.com \
--cc=bfoster@redhat.com \
--cc=chandanrlinux@gmail.com \
--cc=dchinner@redhat.com \
--cc=iamkeyur96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox