From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 193F7C433E0 for ; Tue, 23 Jun 2020 04:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E86B020706 for ; Tue, 23 Jun 2020 04:26:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726077AbgFWE0q (ORCPT ); Tue, 23 Jun 2020 00:26:46 -0400 Received: from mail110.syd.optusnet.com.au ([211.29.132.97]:56054 "EHLO mail110.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgFWE0q (ORCPT ); Tue, 23 Jun 2020 00:26:46 -0400 Received: from dread.disaster.area (pa49-180-124-177.pa.nsw.optusnet.com.au [49.180.124.177]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 79037109E49; Tue, 23 Jun 2020 14:26:43 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jnaW6-0002rZ-L7; Tue, 23 Jun 2020 14:26:38 +1000 Date: Tue, 23 Jun 2020 14:26:38 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: xfs Subject: Re: [PATCH v2] xfs: don't eat an EIO/ENOSPC writeback error when scrubbing data fork Message-ID: <20200623042638.GZ2005@dread.disaster.area> References: <20200623035010.GF7606@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623035010.GF7606@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QIgWuTDL c=1 sm=1 tr=0 a=k3aV/LVJup6ZGWgigO6cSA==:117 a=k3aV/LVJup6ZGWgigO6cSA==:17 a=kj9zAlcOel0A:10 a=nTHF0DUjJn0A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=kYuNqCbEwlqFxAIVCtYA:9 a=tqq6-mpoCbU7iq7c:21 a=8milSOSxcUj7buXt:21 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jun 22, 2020 at 08:50:10PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > The data fork scrubber calls filemap_write_and_wait to flush dirty pages > and delalloc reservations out to disk prior to checking the data fork's > extent mappings. Unfortunately, this means that scrub can consume the > EIO/ENOSPC errors that would otherwise have stayed around in the address > space until (we hope) the writer application calls fsync to persist data > and collect errors. The end result is that programs that wrote to a > file might never see the error code and proceed as if nothing were > wrong. > > xfs_scrub is not in a position to notify file writers about the > writeback failure, and it's only here to check metadata, not file > contents. Therefore, if writeback fails, we should stuff the error code > back into the address space so that an fsync by the writer application > can pick that up. > > Fixes: 99d9d8d05da2 ("xfs: scrub inode block mappings") > Signed-off-by: Darrick J. Wong > --- > v2: explain why it's ok to keep going even if writeback fails Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com