From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2 1/5] xfs: Remove kmem_zone_alloc() usage
Date: Mon, 13 Jul 2020 09:17:18 -0700 [thread overview]
Message-ID: <20200713161718.GW7606@magnolia> (raw)
In-Reply-To: <20200713091610.kooniclgd3curv73@eorzea>
On Mon, Jul 13, 2020 at 11:16:10AM +0200, Carlos Maiolino wrote:
> Hi Dave, Christoph.
>
> > > > - ip = kmem_zone_alloc(xfs_inode_zone, 0);
> > > > +
> > > > + if (current->flags & PF_MEMALLOC_NOFS)
> > > > + gfp_mask |= __GFP_NOFAIL;
> > >
> > > I'm a little worried about this change in beavior here. Can we
> > > just keep the unconditional __GFP_NOFAIL and if we really care do the
> > > change separately after the series? At that point it should probably
> > > use the re-added PF_FSTRANS flag as well.
>
> > Checking PF_FSTRANS was what I suggested should be done here, not
> > PF_MEMALLOC_NOFS...
>
>
> No problem in splitting this change into 2 patches, 1 by unconditionally use
> __GFP_NOFAIL, and another changing the behavior to use NOFAIL only inside a
> transaction.
>
> Regarding the PF_FSTRANS flag, I opted by PF_MEMALLOC_NOFS after reading the
> commit which removed PF_FSTRANS initially (didn't mean to ignore your suggestion
> Dave, my apologies if I sounded like that), but I actually didn't find any commit
> re-adding PF_FSTRANS back. I searched most trees but couldn't find any commit
> re-adding it back, could you guys please point me out where is the commit adding
> it back?
I suspect Dave is referring to:
"xfs: reintroduce PF_FSTRANS for transaction reservation recursion
protection" by Yang Shao.
AFAICT it hasn't cleared akpm yet, so it's not in his quiltpile, and as
he doesn't use git there won't be a commit until it ends up in
mainline...
--D
> >
> > Cheers,
> >
> > Dave.
> > --
> > Dave Chinner
> > david@fromorbit.com
> >
>
> --
> Carlos
>
next prev parent reply other threads:[~2020-07-13 16:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 9:15 [PATCH 0/5] Continue xfs kmem cleanup - V2 Carlos Maiolino
2020-07-10 9:15 ` [PATCH V2 1/5] xfs: Remove kmem_zone_alloc() usage Carlos Maiolino
2020-07-10 16:08 ` Christoph Hellwig
2020-07-10 22:21 ` Dave Chinner
2020-07-13 9:16 ` Carlos Maiolino
2020-07-13 16:17 ` Darrick J. Wong [this message]
2020-07-15 15:06 ` Carlos Maiolino
2020-07-15 15:37 ` Darrick J. Wong
2020-07-15 17:32 ` Christoph Hellwig
2020-07-10 9:15 ` [PATCH V2 2/5] xfs: Remove kmem_zone_zalloc() usage Carlos Maiolino
2020-07-10 16:09 ` Christoph Hellwig
2020-07-10 9:15 ` [PATCH V3 3/5] xfs: Modify xlog_ticket_alloc() to use kernel's MM API Carlos Maiolino
2020-07-10 9:23 ` Carlos Maiolino
2020-07-10 16:09 ` Christoph Hellwig
2020-07-10 9:15 ` [PATCH 4/5] xfs: remove xfs_zone_{alloc,zalloc} helpers Carlos Maiolino
2020-07-10 16:09 ` Christoph Hellwig
2020-07-10 9:15 ` [PATCH 5/5] xfs: Remove xfs_da_state_alloc() helper Carlos Maiolino
2020-07-10 16:11 ` Christoph Hellwig
2020-07-13 9:17 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713161718.GW7606@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).