From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 05/26] xfs: split the incore dquot type into a separate field
Date: Wed, 15 Jul 2020 19:39:48 +0100 [thread overview]
Message-ID: <20200715183948.GA23249@infradead.org> (raw)
In-Reply-To: <20200715183838.GD3151642@magnolia>
On Wed, Jul 15, 2020 at 11:38:38AM -0700, Darrick J. Wong wrote:
> On Wed, Jul 15, 2020 at 06:43:40PM +0100, Christoph Hellwig wrote:
> > On Tue, Jul 14, 2020 at 11:05:02AM -0700, Darrick J. Wong wrote:
> > > On Tue, Jul 14, 2020 at 08:57:56AM +0100, Christoph Hellwig wrote:
> > > > On Mon, Jul 13, 2020 at 06:32:00PM -0700, Darrick J. Wong wrote:
> > > > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > > > >
> > > > > Create a new type (xfs_dqtype_t) to represent the type of an incore
> > > > > dquot. Break the type field out from the dq_flags field of the incore
> > > > > dquot.
> > > >
> > > > I don't understand why we need separate in-core vs on-disk values for
> > > > the type. Why not something like this on top of the whole series:
> > >
> > > I want to keep the ondisk d_type values separate from the incore q_type
> > > values because they don't describe exactly the same concepts:
> > >
> > > First, the incore qtype has a NONE value that we can pass to the dquot
> > > core verifier when we don't actually know if this is a user, group, or
> > > project dquot. This should never end up on disk.
> >
> > Which we can trivially verify. Or just get rid of NONE, which actually
> > cleans things up a fair bit (patch on top of my previous one below)
>
> Ok, I'll get rid of that usage.
>
> > > Second, xfs_dqtype_t is a (barely concealed) enumeration type for quota
> > > callers to tell us that they want to perform an action on behalf of
> > > user, group, or project quotas. The incore q_flags and the ondisk
> > > d_type contain internal state that should not be exposed to quota
> > > callers.
> >
> > I don't think that is an argument, as we do the same elsewhere.
> >
> > >
> > > I feel a need to reiterate that I'm about to start adding more flags to
> > > d_type (for y2038+ time support), for which it will be very important to
> > > keep d_type and q_{type,flags} separate.
> >
> > Why? We'll just OR the bigtime flag in before writing to disk.
>
> Ugh, fine, I'll rework the whole series yet again, since it doesn't look
> like anyone else is going to have the time to review a 27 patch cleanup
> series.
Let's just get your series in and I'll send an incremental patch
after the bigtime series..
next prev parent reply other threads:[~2020-07-15 18:39 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 1:31 [PATCH v3 00/26] xfs: remove xfs_disk_quot from incore dquot Darrick J. Wong
2020-07-14 1:31 ` [PATCH 01/26] xfs: clear XFS_DQ_FREEING if we can't lock the dquot buffer to flush Darrick J. Wong
2020-07-14 1:31 ` [PATCH 02/26] xfs: fix inode quota reservation checks Darrick J. Wong
2020-07-14 1:31 ` [PATCH 03/26] xfs: validate ondisk/incore dquot flags Darrick J. Wong
2020-07-14 1:31 ` [PATCH 04/26] xfs: move the flags argument of xfs_qm_scall_trunc_qfiles to XFS_QMOPT_* Darrick J. Wong
2020-07-14 7:24 ` Christoph Hellwig
2020-07-14 1:32 ` [PATCH 05/26] xfs: split the incore dquot type into a separate field Darrick J. Wong
2020-07-14 7:57 ` Christoph Hellwig
2020-07-14 18:05 ` Darrick J. Wong
2020-07-15 17:43 ` Christoph Hellwig
2020-07-15 18:38 ` Darrick J. Wong
2020-07-15 18:39 ` Christoph Hellwig [this message]
2020-07-15 21:20 ` Darrick J. Wong
2020-07-16 2:17 ` Darrick J. Wong
2020-07-14 1:32 ` [PATCH 06/26] xfs: refactor quotacheck flags usage Darrick J. Wong
2020-07-14 7:58 ` Christoph Hellwig
2020-07-14 1:32 ` [PATCH 07/26] xfs: rename dquot incore state flags Darrick J. Wong
2020-07-14 8:00 ` Christoph Hellwig
2020-07-14 1:32 ` [PATCH 08/26] xfs: move the ondisk dquot flags to their own namespace Darrick J. Wong
2020-07-14 8:05 ` Christoph Hellwig
2020-07-14 18:07 ` Darrick J. Wong
2020-07-14 1:32 ` [PATCH 09/26] xfs: make XFS_DQUOT_CLUSTER_SIZE_FSB part of the ondisk format Darrick J. Wong
2020-07-14 1:32 ` [PATCH 10/26] xfs: stop using q_core.d_flags in the quota code Darrick J. Wong
2020-07-14 8:00 ` Christoph Hellwig
2020-07-14 1:32 ` [PATCH 11/26] xfs: stop using q_core.d_id " Darrick J. Wong
2020-07-14 1:32 ` [PATCH 12/26] xfs: use a per-resource struct for incore dquot data Darrick J. Wong
2020-07-14 1:32 ` [PATCH 13/26] xfs: stop using q_core limits in the quota code Darrick J. Wong
2020-07-14 1:32 ` [PATCH 14/26] xfs: stop using q_core counters " Darrick J. Wong
2020-07-14 1:33 ` [PATCH 15/26] xfs: stop using q_core warning " Darrick J. Wong
2020-07-14 1:33 ` [PATCH 16/26] xfs: stop using q_core timers " Darrick J. Wong
2020-07-14 1:33 ` [PATCH 17/26] xfs: remove qcore from incore dquots Darrick J. Wong
2020-07-14 1:33 ` [PATCH 18/26] xfs: refactor default quota limits by resource Darrick J. Wong
2020-07-14 1:33 ` [PATCH 19/26] xfs: remove unnecessary arguments from quota adjust functions Darrick J. Wong
2020-07-14 1:33 ` [PATCH 20/26] xfs: refactor quota exceeded test Darrick J. Wong
2020-07-14 8:01 ` Christoph Hellwig
2020-07-14 1:33 ` [PATCH 21/26] xfs: refactor xfs_qm_scall_setqlim Darrick J. Wong
2020-07-14 1:33 ` [PATCH 22/26] xfs: refactor xfs_trans_dqresv Darrick J. Wong
2020-07-14 8:01 ` Christoph Hellwig
2020-07-14 1:33 ` [PATCH 23/26] xfs: refactor xfs_trans_apply_dquot_deltas Darrick J. Wong
2020-07-14 8:02 ` Christoph Hellwig
2020-07-14 1:34 ` [PATCH 24/26] xfs: assume the default quota limits are always set in xfs_qm_adjust_dqlimits Darrick J. Wong
2020-07-14 8:02 ` Christoph Hellwig
2020-07-14 1:34 ` [PATCH 25/26] xfs: actually bump warning counts when we send warnings Darrick J. Wong
2020-07-14 8:03 ` Christoph Hellwig
2020-07-14 1:34 ` [PATCH 26/26] xfs: add more dquot tracepoints Darrick J. Wong
2020-07-14 8:03 ` Christoph Hellwig
2020-07-14 1:43 ` [PATCH v3 00/26] xfs: remove xfs_disk_quot from incore dquot Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-07-15 1:50 [PATCH v4 " Darrick J. Wong
2020-07-15 1:51 ` [PATCH 05/26] xfs: split the incore dquot type into a separate field Darrick J. Wong
2020-07-16 6:59 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715183948.GA23249@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).