Re: [PATCH v2 10/11] xfs: improve ondisk dquot flags checking

Christoph Hellwig
2020-07-21T14:58:56Z

On Thu, Jul 16, 2020 at 06:12:55PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Create an XFS_DQTYPE_ANY mask for ondisk dquots flags, and use that to
> ensure that we never accept any garbage flags when we're loading dquots.
> While we're at it, restructure the quota type flag checking to use the
> proper masking.
>
> Note that I plan to add y2038 support soon, which will require a new
> xfs_dqtype_t flag for extended timestamp support, hence all the work to
> make the type masking work correctly.

I'd have delayed this until we actually add a the bigtime flag. But
I don't want you to respin once again, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>