From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAFBC433E0 for ; Fri, 17 Jul 2020 00:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 433D3206F4 for ; Fri, 17 Jul 2020 00:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726167AbgGQABU (ORCPT ); Thu, 16 Jul 2020 20:01:20 -0400 Received: from mail106.syd.optusnet.com.au ([211.29.132.42]:59632 "EHLO mail106.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgGQABU (ORCPT ); Thu, 16 Jul 2020 20:01:20 -0400 Received: from dread.disaster.area (pa49-180-53-24.pa.nsw.optusnet.com.au [49.180.53.24]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 0E1BB5ED4A0; Fri, 17 Jul 2020 10:01:12 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jwDoJ-0001XE-W1; Fri, 17 Jul 2020 10:01:07 +1000 Date: Fri, 17 Jul 2020 10:01:07 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 07/11] xfs: remove unnecessary quota type masking Message-ID: <20200717000107.GT2005@dread.disaster.area> References: <159488191927.3813063.6443979621452250872.stgit@magnolia> <159488196391.3813063.17612590871057481605.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159488196391.3813063.17612590871057481605.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=moVtWZxmCkf3aAMJKIb/8g==:117 a=moVtWZxmCkf3aAMJKIb/8g==:17 a=kj9zAlcOel0A:10 a=_RQrkK6FrEwA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=1ODI7Dv5FDElEThLlyIA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jul 15, 2020 at 11:46:03PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > When XFS' quota functions take a parameter for the quota type, they only > care about the three quota record types (user, group, project). > Internal state flags and whatnot should never be passed by callers and > are an error. Now that we've moved responsibility for filtering out > internal state to the callers, we can drop the masking everywhere else. > > In other words, if you call a quota function, you must only pass in > XFS_DQTYPE_*. > > Signed-off-by: Darrick J. Wong Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com