From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A33FC433E2 for ; Fri, 17 Jul 2020 01:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F8A12076D for ; Fri, 17 Jul 2020 01:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbgGQBSx (ORCPT ); Thu, 16 Jul 2020 21:18:53 -0400 Received: from mail109.syd.optusnet.com.au ([211.29.132.80]:37222 "EHLO mail109.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbgGQBSx (ORCPT ); Thu, 16 Jul 2020 21:18:53 -0400 Received: from dread.disaster.area (pa49-180-53-24.pa.nsw.optusnet.com.au [49.180.53.24]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id B91E6D7B6D1; Fri, 17 Jul 2020 11:18:50 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jwF1V-0001uN-4R; Fri, 17 Jul 2020 11:18:49 +1000 Date: Fri, 17 Jul 2020 11:18:49 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 10/11] xfs: improve ondisk dquot flags checking Message-ID: <20200717011849.GA2005@dread.disaster.area> References: <159488191927.3813063.6443979621452250872.stgit@magnolia> <159488198306.3813063.16348101518917273554.stgit@magnolia> <20200717011255.GM3151642@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717011255.GM3151642@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QIgWuTDL c=1 sm=1 tr=0 a=moVtWZxmCkf3aAMJKIb/8g==:117 a=moVtWZxmCkf3aAMJKIb/8g==:17 a=kj9zAlcOel0A:10 a=_RQrkK6FrEwA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=dq43kg-EE1T-g2Jv4ggA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Jul 16, 2020 at 06:12:55PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Create an XFS_DQTYPE_ANY mask for ondisk dquots flags, and use that to > ensure that we never accept any garbage flags when we're loading dquots. > While we're at it, restructure the quota type flag checking to use the > proper masking. > > Note that I plan to add y2038 support soon, which will require a new > xfs_dqtype_t flag for extended timestamp support, hence all the work to > make the type masking work correctly. > > Signed-off-by: Darrick J. Wong > --- > v2: amend commit message > --- Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com