Re: [PATCH 07/11] xfs: remove unnecessary quota type masking

Dave Chinner
2020-07-17T00:01:21Z

On Wed, Jul 15, 2020 at 11:46:03PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When XFS' quota functions take a parameter for the quota type, they only
> care about the three quota record types (user, group, project).
> Internal state flags and whatnot should never be passed by callers and
> are an error. Now that we've moved responsibility for filtering out
> internal state to the callers, we can drop the masking everywhere else.
>
> In other words, if you call a quota function, you must only pass in
> XFS_DQTYPE_*.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com