From: Carlos Maiolino <cmaiolino@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] xfs: Remove kmem_zone_alloc() usage
Date: Thu, 23 Jul 2020 11:02:31 +0200 [thread overview]
Message-ID: <20200723090231.ulsyoikyzvfjo3mo@eorzea> (raw)
In-Reply-To: <20200722141346.GA20266@infradead.org>
On Wed, Jul 22, 2020 at 03:13:46PM +0100, Christoph Hellwig wrote:
> On Wed, Jul 22, 2020 at 11:05:14AM +0200, Carlos Maiolino wrote:
> > - /*
> > - * if this didn't occur in transactions, we could use
> > - * KM_MAYFAIL and return NULL here on ENOMEM. Set the
> > - * code up to do this anyway.
> > - */
> > - ip = kmem_zone_alloc(xfs_inode_zone, 0);
> > - if (!ip)
> > - return NULL;
> > + ip = kmem_cache_alloc(xfs_inode_zone, GFP_KERNEL | __GFP_NOFAIL);
> > +
>
> I would have kept a version of this comment. But if this on your
> radar for the next merge window anyway this should be ok:
I thought it makes no sense to keep the comment, and yes, I'll keep an eye on it
and rework this as soon as we have PF_FSTRANS back.
Thanks for the review.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
--
Carlos
next prev parent reply other threads:[~2020-07-23 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 9:05 [PATCH 0/5] Continue xfs kmem cleanup - V3 Carlos Maiolino
2020-07-22 9:05 ` [PATCH 1/5] xfs: Remove kmem_zone_alloc() usage Carlos Maiolino
2020-07-22 14:13 ` Christoph Hellwig
2020-07-23 9:02 ` Carlos Maiolino [this message]
2020-07-24 1:40 ` Dave Chinner
2020-07-24 5:36 ` Darrick J. Wong
2020-07-22 9:05 ` [PATCH 2/5] xfs: Remove kmem_zone_zalloc() usage Carlos Maiolino
2020-07-24 1:41 ` Dave Chinner
2020-07-24 5:39 ` Darrick J. Wong
2020-07-22 9:05 ` [PATCH 3/5] xfs: Modify xlog_ticket_alloc() to use kernel's MM API Carlos Maiolino
2020-07-24 1:41 ` Dave Chinner
2020-07-24 5:39 ` Darrick J. Wong
2020-07-22 9:05 ` [PATCH 4/5] xfs: remove xfs_zone_{alloc,zalloc} helpers Carlos Maiolino
2020-07-24 5:40 ` Darrick J. Wong
2020-07-22 9:05 ` [PATCH 5/5] xfs: Refactor xfs_da_state_alloc() helper Carlos Maiolino
2020-07-22 14:15 ` Christoph Hellwig
2020-07-24 1:42 ` Dave Chinner
2020-07-24 5:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723090231.ulsyoikyzvfjo3mo@eorzea \
--to=cmaiolino@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox