public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 00/10] Bail out if transaction can cause extent count to overflow
@ 2020-08-14  8:08 Chandan Babu R
  2020-08-14  8:08 ` [PATCH V2 01/10] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
                   ` (9 more replies)
  0 siblings, 10 replies; 22+ messages in thread
From: Chandan Babu R @ 2020-08-14  8:08 UTC (permalink / raw)
  To: linux-xfs; +Cc: Chandan Babu R, darrick.wong, david

XFS does not check for possible overflow of per-inode extent counter
fields when adding extents to either data or attr fork.

For e.g.
1. Insert 5 million xattrs (each having a value size of 255 bytes) and
   then delete 50% of them in an alternating manner.

2. On a 4k block sized XFS filesystem instance, the above causes 98511
   extents to be created in the attr fork of the inode.

   xfsaild/loop0  2035 [003]  9643.390490: probe:xfs_iflush_int: (ffffffffac6225c0) if_nextents=98511 inode=131

3. The incore inode fork extent counter is a signed 32-bit
   quantity. However the on-disk extent counter is an unsigned 16-bit
   quantity and hence cannot hold 98511 extents.

4. The following incorrect value is stored in the xattr extent counter,
   # xfs_db -f -c 'inode 131' -c 'print core.naextents' /dev/loop0
   core.naextents = -32561

This patchset adds a new helper function
(i.e. xfs_iext_count_may_overflow()) to check for overflow of the
per-inode data and xattr extent counters and invokes it before
starting an fs operation (e.g. creating a new directory entry). With
this patchset applied, XFS detects counter overflows and returns with
an error rather than causing a silent corruption.

The patchset has been tested by executing xfstests with the following
mkfs.xfs options,
1. -m crc=0 -b size=1k
2. -m crc=0 -b size=4k
3. -m crc=0 -b size=512
4. -m rmapbt=1,reflink=1 -b size=1k
5. -m rmapbt=1,reflink=1 -b size=4k

The patches can also be obtained from
https://github.com/chandanr/linux.git at branch xfs-reserve-extent-count-v2.

Changelog:
V1 -> V2:
  1. Rename helper function from xfs_trans_resv_ext_cnt() to
     xfs_iext_count_may_overflow().
  2. Define and use macros to represent fs operations and the
     corresponding increase in extent count.
  3. Split the patches based on the fs operation being performed.

Chandan Babu R (10):
  xfs: Add helper for checking per-inode extent count overflow
  xfs: Check for extent overflow when trivally adding a new extent
  xfs: Check for extent overflow when deleting an extent
  xfs: Check for extent overflow when adding/removing xattrs
  xfs: Check for extent overflow when adding/removing dir entries
  xfs: Check for extent overflow when writing to unwritten extent
  xfs: Check for extent overflow when inserting a hole
  xfs: Check for extent overflow when moving extent from cow to data
    fork
  xfs: Check for extent overflow when remapping an extent
  xfs: Check for extent overflow when swapping extents

 fs/xfs/libxfs/xfs_attr.c       | 13 ++++++
 fs/xfs/libxfs/xfs_bmap.c       |  8 ++++
 fs/xfs/libxfs/xfs_inode_fork.h | 72 ++++++++++++++++++++++++++++++++++
 fs/xfs/libxfs/xfs_trans_resv.c | 33 ++++++++++++++++
 fs/xfs/libxfs/xfs_trans_resv.h |  2 +
 fs/xfs/xfs_bmap_item.c         |  4 ++
 fs/xfs/xfs_bmap_util.c         | 30 ++++++++++++++
 fs/xfs/xfs_dquot.c             |  8 +++-
 fs/xfs/xfs_inode.c             | 27 +++++++++++++
 fs/xfs/xfs_iomap.c             | 10 +++++
 fs/xfs/xfs_reflink.c           | 11 ++++++
 fs/xfs/xfs_rtalloc.c           |  5 +++
 fs/xfs/xfs_symlink.c           |  5 +++
 13 files changed, 227 insertions(+), 1 deletion(-)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2020-08-27 14:46 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-14  8:08 [PATCH V2 00/10] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 01/10] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-08-17  6:51   ` Christoph Hellwig
2020-08-17  7:44     ` Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 02/10] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-08-17  6:53   ` Christoph Hellwig
2020-08-17  7:44     ` Chandan Babu R
2020-08-27  8:09       ` Christoph Hellwig
2020-08-27 13:51         ` Chandan Babu R
2020-08-18 21:49     ` Dave Chinner
2020-08-18 21:57       ` Darrick J. Wong
2020-08-19  4:43         ` Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 03/10] xfs: Check for extent overflow when deleting an extent Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 04/10] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 05/10] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 06/10] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 07/10] xfs: Check for extent overflow when inserting a hole Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 08/10] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-08-18 22:03   ` Darrick J. Wong
2020-08-19  5:04     ` Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 09/10] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-08-14  8:08 ` [PATCH V2 10/10] xfs: Check for extent overflow when swapping extents Chandan Babu R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox