From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH v2 4/4] mkfs: allow setting dax flag on root directory
Date: Mon, 17 Aug 2020 08:43:01 -0700 [thread overview]
Message-ID: <20200817154301.GL6096@magnolia> (raw)
In-Reply-To: <159736126408.3063459.10843086291491627861.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Teach mkfs to set the DAX flag on the root directory so that all new
files can be created in dax mode. This is a complement to removing the
mount option.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
---
v2: minor tweak to manpage text
---
man/man8/mkfs.xfs.8 | 10 ++++++++++
mkfs/xfs_mkfs.c | 14 ++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 7d3f3552ff12..0a7858748457 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -398,6 +398,16 @@ will have this extent size hint applied.
The value must be provided in units of filesystem blocks.
Directories will pass on this hint to newly created regular files and
directories.
+.TP
+.BI daxinherit= value
+If set, all inodes created by
+.B mkfs.xfs
+will be created with the DAX flag set.
+Directories will pass on this flag to newly created regular files and
+directories.
+By default,
+.B mkfs.xfs
+will not enable DAX mode.
.RE
.TP
.B \-f
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 2e6cd280e388..a687f385a9c1 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -60,6 +60,7 @@ enum {
D_PROJINHERIT,
D_EXTSZINHERIT,
D_COWEXTSIZE,
+ D_DAXINHERIT,
D_MAX_OPTS,
};
@@ -254,6 +255,7 @@ static struct opt_params dopts = {
[D_PROJINHERIT] = "projinherit",
[D_EXTSZINHERIT] = "extszinherit",
[D_COWEXTSIZE] = "cowextsize",
+ [D_DAXINHERIT] = "daxinherit",
},
.subopt_params = {
{ .index = D_AGCOUNT,
@@ -369,6 +371,12 @@ static struct opt_params dopts = {
.maxval = UINT_MAX,
.defaultval = SUBOPT_NEEDS_VAL,
},
+ { .index = D_DAXINHERIT,
+ .conflicts = { { NULL, LAST_CONFLICT } },
+ .minval = 0,
+ .maxval = 1,
+ .defaultval = 1,
+ },
},
};
@@ -1434,6 +1442,12 @@ data_opts_parser(
cli->fsx.fsx_cowextsize = getnum(value, opts, subopt);
cli->fsx.fsx_xflags |= FS_XFLAG_COWEXTSIZE;
break;
+ case D_DAXINHERIT:
+ if (getnum(value, opts, subopt))
+ cli->fsx.fsx_xflags |= FS_XFLAG_DAX;
+ else
+ cli->fsx.fsx_xflags &= ~FS_XFLAG_DAX;
+ break;
default:
return -EINVAL;
}
prev parent reply other threads:[~2020-08-17 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 23:27 [PATCH v2 0/4] xfsprogs: various small enhancements Darrick J. Wong
2020-08-13 23:27 ` [PATCH 1/4] xfs_db: fix nlink usage in check Darrick J. Wong
2020-08-17 6:53 ` Christoph Hellwig
2020-08-17 11:25 ` Carlos Maiolino
2020-08-13 23:27 ` [PATCH 2/4] xfs_db: report the inode dax flag Darrick J. Wong
2020-08-17 6:53 ` Christoph Hellwig
2020-08-17 11:26 ` Carlos Maiolino
2020-08-13 23:27 ` [PATCH 3/4] man: update mkfs.xfs inode flag option documentation Darrick J. Wong
2020-08-17 6:54 ` Christoph Hellwig
2020-08-17 11:27 ` Carlos Maiolino
2020-08-13 23:27 ` [PATCH 4/4] mkfs: allow setting dax flag on root directory Darrick J. Wong
2020-08-17 6:54 ` Christoph Hellwig
2020-08-17 11:30 ` Carlos Maiolino
2020-08-17 15:41 ` Darrick J. Wong
2020-08-17 15:43 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817154301.GL6096@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox