Re: [PATCH] xfs: use log_incompat feature instead of speculate matching

Christoph Hellwig
2020-08-27T07:20:07Z

On Tue, Aug 25, 2020 at 07:54:58AM -0700, Darrick J. Wong wrote:
> > + XFS_SB_VERSION2_FTYPE | \
> > + XFS_SB_VERSION2_NEW_IUNLINK)
>
> NAK on this part; as I said earlier, don't add things to V4 filesystems.
>
> If the rest of you have compelling reasons to want V4 support, now is
> the time to speak up.

I think that it because the series uses the longer unhashed chains
unconditionally. And given that old kernels can't deal with that
at all I suspect that needs to be changed and support the old buckets
for old file systems. And once that is done I don't think we should
enable the long single chain without the log item anyway, and remove
another possibly combination of flags.