Re: [PATCH V3 09/10] xfs: Check for extent overflow when remapping an extent

Chandan Babu R
2020-09-01T09:45:42Z

On Monday 31 August 2020 9:53:35 PM IST Darrick J. Wong wrote:
> On Thu, Aug 20, 2020 at 11:13:48AM +0530, Chandan Babu R wrote:
> > Remapping an extent involves unmapping the existing extent and mapping
> > in the new extent. When unmapping, an extent containing the entire unmap
> > range can be split into two extents,
> > i.e. | Old extent | hole | Old extent |
> > Hence extent count increases by 1.
> >
> > Mapping in the new extent into the destination file can increase the
> > extent count by 1.
> >
> > Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> > ---
> > fs/xfs/libxfs/xfs_inode_fork.h | 14 ++++++++++++++
> > fs/xfs/xfs_reflink.c | 5 +++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/fs/xfs/libxfs/xfs_inode_fork.h b/fs/xfs/libxfs/xfs_inode_fork.h
> > index 850d53162545..d1c675cf803a 100644
> > --- a/fs/xfs/libxfs/xfs_inode_fork.h
> > +++ b/fs/xfs/libxfs/xfs_inode_fork.h
> > @@ -86,6 +86,20 @@ struct xfs_ifork {
> > * Hence number of extents increases by 2.
> > */
> > #define XFS_IEXT_REFLINK_END_COW_CNT (2)
> > +/*
>
> It's usually considered good style to put a blank line between the
> previous definition and the new comment.
>

Ok. I will fix that.

> With that fixed,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>

--
chandan