From: Christoph Hellwig <hch@infradead.org>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: Gao Xiang <hsiangkao@redhat.com>,
hch@infradead.org, darrick.wong@oracle.com, willy@infradead.org,
david@fromorbit.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [RFC PATCH V3] iomap: add support to track dirty state of sub pages
Date: Fri, 21 Aug 2020 07:12:34 +0100 [thread overview]
Message-ID: <20200821061234.GE31091@infradead.org> (raw)
In-Reply-To: <43dc04bf-17bb-9f15-4f1c-dfd6c47c3fb1@huawei.com>
On Thu, Aug 20, 2020 at 09:38:53AM +0800, yukuai (C) wrote:
> > > +iomap_set_range_dirty(struct page *page, unsigned int off,
> > > + unsigned int len)
> > > +{
> > > + if (PageError(page))
> > > + return;
> > > +
> > > + if (page_has_private(page))
> > > + iomap_iop_set_range_dirty(page, off, len);
> >
> >
> > I vaguely remembered iomap doesn't always set up PagePrivate.
> >
>
> If so, maybe I should move iomap_set_page_dirty() to
> ioamp_set_range_dirty().
iomap sets PagePrivate if a iomap_page structure is allocated. Right
now that means for all pages on a file system with a block size smaller
than the page size, although I hope we reduce that scope a little.
next prev parent reply other threads:[~2020-08-21 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:05 [RFC PATCH V3] iomap: add support to track dirty state of sub pages Yu Kuai
2020-08-19 12:56 ` Gao Xiang
2020-08-20 1:38 ` yukuai (C)
2020-08-21 6:12 ` Christoph Hellwig [this message]
2020-08-21 13:36 ` Matthew Wilcox
2020-08-22 6:03 ` Christoph Hellwig
2020-08-22 14:24 ` Matthew Wilcox
2020-08-22 16:43 ` Christoph Hellwig
2020-08-21 6:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821061234.GE31091@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hsiangkao@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox