From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D784C433DF for ; Sat, 22 Aug 2020 06:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35E7920724 for ; Sat, 22 Aug 2020 06:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FMgzhJe6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbgHVGBS (ORCPT ); Sat, 22 Aug 2020 02:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbgHVGBR (ORCPT ); Sat, 22 Aug 2020 02:01:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CE02C061573; Fri, 21 Aug 2020 23:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4sW5NkGTIdZnLEpGZfOYW+uwnHM3SBAF6ctXgNKOsBM=; b=FMgzhJe6qwurPFWFxaW9fv8Ayg pBipEcF9XSC9CCiDdI6btVjfI+CHQWE9Y8W7rqB5crMEiPOqAp5Yoa95AdDa721tzZJ2exGAJkz2W k8IRmFv//HP2CdqAYPWXbKigGKszBhiV+I1jIrhmULi8r3qLUtc169ixmjGjnd99WqwqydBOrgU0Q UDVscmzUMfGr5ukS4z8eUupEV6XjSIzJkZ/E58R4S7jy8Zte9YCTs8lYVPlmkbcHFvjHbB1FSEqHS EsMcEPdJajhPSmy9sXk3Ya9nl04dyLBzH0PGkFfuJCMAmZHUt85mN1C5d+RAeRFow7dVKV7wOMMAZ F0UHpqlQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9MaW-0004kO-AZ; Sat, 22 Aug 2020 06:01:12 +0000 Date: Sat, 22 Aug 2020 07:01:12 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Yu Kuai , hch@infradead.org, darrick.wong@oracle.com, david@fromorbit.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH 3/3] iomap: Support arbitrarily many blocks per page Message-ID: <20200822060112.GC17129@infradead.org> References: <20200821124424.GQ17456@casper.infradead.org> <20200821124606.10165-1-willy@infradead.org> <20200821124606.10165-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821124606.10165-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Aug 21, 2020 at 01:46:06PM +0100, Matthew Wilcox (Oracle) wrote: > Size the uptodate array dynamically and add a few debugging assertions. Needs a rebase to not require i_blocks_per_page, and a somewhat more details changelog that requires why we change this. Otherwise this looks good and should probably go in before the per-block uptodate tracking.