From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6523FC433E1 for ; Mon, 24 Aug 2020 00:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 495E420720 for ; Mon, 24 Aug 2020 00:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbgHXAEM (ORCPT ); Sun, 23 Aug 2020 20:04:12 -0400 Received: from mail107.syd.optusnet.com.au ([211.29.132.53]:54162 "EHLO mail107.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgHXAEM (ORCPT ); Sun, 23 Aug 2020 20:04:12 -0400 Received: from dread.disaster.area (pa49-181-146-199.pa.nsw.optusnet.com.au [49.181.146.199]) by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id 0540CD5BBD4; Mon, 24 Aug 2020 10:04:03 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1k9zxz-0000nZ-Ck; Mon, 24 Aug 2020 10:04:03 +1000 Date: Mon, 24 Aug 2020 10:04:03 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Amir Goldstein , linux-xfs@vger.kernel.org, sandeen@sandeen.net Subject: Re: [PATCH 04/11] xfs: remove xfs_timestamp_t Message-ID: <20200824000403.GM7941@dread.disaster.area> References: <159797588727.965217.7260803484540460144.stgit@magnolia> <159797591321.965217.7549298717995336302.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159797591321.965217.7549298717995336302.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LPwYv6e9 c=1 sm=1 tr=0 cx=a_idp_d a=GorAHYkI+xOargNMzM6qxQ==:117 a=GorAHYkI+xOargNMzM6qxQ==:17 a=kj9zAlcOel0A:10 a=y4yBn9ojGxQA:10 a=yPCof4ZbAAAA:8 a=pGLkceISAAAA:8 a=7-415B0cAAAA:8 a=MsLoL6ZKfrea_UzeC0kA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Aug 20, 2020 at 07:11:53PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Kill this old typedef. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Amir Goldstein > --- > fs/xfs/libxfs/xfs_format.h | 12 ++++++------ > fs/xfs/libxfs/xfs_log_format.h | 12 ++++++------ > 2 files changed, 12 insertions(+), 12 deletions(-) wouldn't it be less churn to remove this later when struct xfs_timestamp is converted to a union? Cheers, Dave. -- Dave Chinner david@fromorbit.com