From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Amir Goldstein <amir73il@gmail.com>,
linux-xfs@vger.kernel.org, sandeen@sandeen.net
Subject: Re: [PATCH 07/11] xfs: convert struct xfs_timestamp to union
Date: Sun, 23 Aug 2020 19:35:43 -0700 [thread overview]
Message-ID: <20200824023543.GQ6096@magnolia> (raw)
In-Reply-To: <20200822071830.GG1629@infradead.org>
On Sat, Aug 22, 2020 at 08:18:30AM +0100, Christoph Hellwig wrote:
> On Thu, Aug 20, 2020 at 07:12:15PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Convert the xfs_timestamp struct to a union so that we can overload it
> > in the next patch.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> > ---
> > fs/xfs/libxfs/xfs_format.h | 16 +++++++++-------
> > fs/xfs/libxfs/xfs_inode_buf.c | 4 ++--
> > fs/xfs/libxfs/xfs_inode_buf.h | 4 ++--
> > fs/xfs/libxfs/xfs_log_format.h | 16 +++++++++-------
> > fs/xfs/scrub/inode.c | 2 +-
> > fs/xfs/xfs_inode_item.c | 6 +++---
> > fs/xfs/xfs_ondisk.h | 4 ++--
> > 7 files changed, 28 insertions(+), 24 deletions(-)
> >
> >
> > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> > index 1f3a2be6c396..772113db41aa 100644
> > --- a/fs/xfs/libxfs/xfs_format.h
> > +++ b/fs/xfs/libxfs/xfs_format.h
> > @@ -856,9 +856,11 @@ struct xfs_agfl {
> > * Inode timestamps consist of signed 32-bit counters for seconds and
> > * nanoseconds; time zero is the Unix epoch, Jan 1 00:00:00 UTC 1970.
> > */
> > -struct xfs_timestamp {
> > - __be32 t_sec; /* timestamp seconds */
> > - __be32 t_nsec; /* timestamp nanoseconds */
> > +union xfs_timestamp {
> > + struct {
> > + __be32 t_sec; /* timestamp seconds */
> > + __be32 t_nsec; /* timestamp nanoseconds */
> > + };
> > };
>
> Wouldn't it make sense to merge the typedef removal patch into this
> one to avoid touching all the users twice?
Will fix. I wasn't sure if people would howl about making both changes
at once, and it's easier to combine two patches. ;)
--D
next prev parent reply other threads:[~2020-08-24 2:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 2:11 [PATCH v3 00/11] xfs: widen timestamps to deal with y2038 Darrick J. Wong
2020-08-21 2:11 ` [PATCH 01/11] xfs: explicitly define inode timestamp range Darrick J. Wong
2020-08-22 7:12 ` Christoph Hellwig
2020-08-24 16:29 ` Darrick J. Wong
2020-08-23 23:54 ` Dave Chinner
2020-08-24 2:34 ` Darrick J. Wong
2020-08-21 2:11 ` [PATCH 02/11] xfs: refactor quota expiration timer modification Darrick J. Wong
2020-08-22 7:14 ` Christoph Hellwig
2020-08-23 23:57 ` Dave Chinner
2020-08-24 2:34 ` Darrick J. Wong
2020-08-21 2:11 ` [PATCH 03/11] xfs: refactor default quota grace period setting code Darrick J. Wong
2020-08-22 7:15 ` Christoph Hellwig
2020-08-24 0:01 ` Dave Chinner
2020-08-21 2:11 ` [PATCH 04/11] xfs: remove xfs_timestamp_t Darrick J. Wong
2020-08-22 7:15 ` Christoph Hellwig
2020-08-24 0:04 ` Dave Chinner
2020-08-21 2:12 ` [PATCH 05/11] xfs: move xfs_log_dinode_to_disk to the log code Darrick J. Wong
2020-08-22 7:16 ` Christoph Hellwig
2020-08-24 2:31 ` Darrick J. Wong
2020-08-24 0:06 ` Dave Chinner
2020-08-21 2:12 ` [PATCH 06/11] xfs: refactor inode timestamp coding Darrick J. Wong
2020-08-22 7:17 ` Christoph Hellwig
2020-08-24 0:10 ` Dave Chinner
2020-08-21 2:12 ` [PATCH 07/11] xfs: convert struct xfs_timestamp to union Darrick J. Wong
2020-08-22 7:18 ` Christoph Hellwig
2020-08-24 2:35 ` Darrick J. Wong [this message]
2020-08-21 2:12 ` [PATCH 08/11] xfs: widen ondisk timestamps to deal with y2038 problem Darrick J. Wong
2020-08-22 7:33 ` Christoph Hellwig
2020-08-24 2:43 ` Darrick J. Wong
2020-08-25 0:39 ` Darrick J. Wong
2020-08-24 1:25 ` Dave Chinner
2020-08-24 3:13 ` Darrick J. Wong
2020-08-24 6:15 ` Dave Chinner
2020-08-24 16:24 ` Darrick J. Wong
2020-08-24 21:13 ` Darrick J. Wong
2020-08-21 2:12 ` [PATCH 09/11] xfs: refactor quota timestamp coding Darrick J. Wong
2020-08-22 7:33 ` Christoph Hellwig
2020-08-24 2:38 ` Darrick J. Wong
2020-08-21 2:12 ` [PATCH 10/11] xfs: enable bigtime for quota timers Darrick J. Wong
2020-08-22 7:36 ` Christoph Hellwig
2020-08-24 2:39 ` Darrick J. Wong
2020-08-21 2:12 ` [PATCH 11/11] xfs: enable big timestamps Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 22:56 [PATCH v2 00/11] xfs: widen timestamps to deal with y2038 Darrick J. Wong
2020-08-17 22:57 ` [PATCH 07/11] xfs: convert struct xfs_timestamp to union Darrick J. Wong
2020-08-18 11:24 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824023543.GQ6096@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox