From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] build: add support for libinih for mkfs
Date: Thu, 27 Aug 2020 08:05:58 +1000 [thread overview]
Message-ID: <20200826220558.GX12131@dread.disaster.area> (raw)
In-Reply-To: <18ce951d-c209-9c60-3f6c-0c7989c587ae@sandeen.net>
On Wed, Aug 26, 2020 at 04:51:50PM -0500, Eric Sandeen wrote:
> On 8/25/20 8:56 PM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Need to make sure the library is present so we can build mkfs with
> > config file support.
>
> Can you add https://github.com/benhoyt/inih to doc/INSTALL as a
> dependency?
Distros should be shipping that library, and configure asks you to
install it if it isn't present, just like it does for all the other
libraries xfsprogs depends on. We want users to install distro
libraries, not have to build dependencies from source and install
them...
> (that's probably pretty out of date now anyway but it seems worth
> documenting any new requirement)
Yeah, we need a lot more than just e2fsprogs-devel and UUIDs these
days. I'd prefer that doc/INSTALL just says "the configure script
will prompt you to install missing build dependencies" rather than
iterate them here and have the list be perpetually incomplete....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-08-26 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 1:56 [PATCH 0/3] mkfs: Configuration file defined options Dave Chinner
2020-08-26 1:56 ` [PATCH 1/3] build: add support for libinih for mkfs Dave Chinner
2020-08-26 21:51 ` Eric Sandeen
2020-08-26 22:05 ` Dave Chinner [this message]
2020-08-26 1:56 ` [PATCH 2/3] mkfs: add initial ini format config file parsing support Dave Chinner
2020-08-26 21:56 ` Eric Sandeen
2020-08-26 22:09 ` Dave Chinner
2020-08-26 1:56 ` [PATCH 3/3] mkfs: hook up suboption parsing to ini files Dave Chinner
2020-08-26 22:21 ` Eric Sandeen
2020-08-26 23:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826220558.GX12131@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox