From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] mkfs: add initial ini format config file parsing support
Date: Thu, 27 Aug 2020 08:09:18 +1000 [thread overview]
Message-ID: <20200826220918.GY12131@dread.disaster.area> (raw)
In-Reply-To: <9a66f54e-c4ec-4a3f-5238-89a262bd45a1@sandeen.net>
On Wed, Aug 26, 2020 at 04:56:34PM -0500, Eric Sandeen wrote:
> On 8/25/20 8:56 PM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Add the framework that will allow the config file to be supplied on
> > the CLI and passed to the library that will parse it. This does not
> > yet do any option parsing from the config file.
>
> so we have "-c $SUBOPT=file"
>
> From what I read in the cover letter, and from checking in IRC it seems
> like you envision the ability to also specify defaults from a config file
> in the future; to that end it might be better to name this $SUBOPT
> "options=" instead of "file=" as the latter is very generic.
>
> Then in the future, we could have one or both of :
>
> -c defaults=file1 -c options=file2
>
> i.e. configure the defaults, then configure the options
Yup, makes sense. Will change.
> I guess this is just RFC but you want probably to drop the "Ini debug:"
> printf eventually.
Yeah, I've already removed that so I can run fstests....
> This will need a man page update, of course.
Eventually, yes :P
> I think it should explain where "file" will be looked for; I assume it
> is either a full path, or a relative path to the current directory.
It will work with either, just like all the other "file" parameters
passed to mkfs....
> (In the future it would be nice to have mkfs.xfs search somewhere
> under /etc for these files as well, but I'm not bikeshedding!)
Nope, I'm not doing that. Go away. :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-08-26 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 1:56 [PATCH 0/3] mkfs: Configuration file defined options Dave Chinner
2020-08-26 1:56 ` [PATCH 1/3] build: add support for libinih for mkfs Dave Chinner
2020-08-26 21:51 ` Eric Sandeen
2020-08-26 22:05 ` Dave Chinner
2020-08-26 1:56 ` [PATCH 2/3] mkfs: add initial ini format config file parsing support Dave Chinner
2020-08-26 21:56 ` Eric Sandeen
2020-08-26 22:09 ` Dave Chinner [this message]
2020-08-26 1:56 ` [PATCH 3/3] mkfs: hook up suboption parsing to ini files Dave Chinner
2020-08-26 22:21 ` Eric Sandeen
2020-08-26 23:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826220918.GY12131@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox