From: Christoph Hellwig <hch@infradead.org>
To: Chandan Babu R <chandanrlinux@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
david@fromorbit.com
Subject: Re: [PATCH V2 02/10] xfs: Check for extent overflow when trivally adding a new extent
Date: Thu, 27 Aug 2020 09:09:03 +0100 [thread overview]
Message-ID: <20200827080903.GA7605@infradead.org> (raw)
In-Reply-To: <1740557.YaExq995uO@garuda>
On Mon, Aug 17, 2020 at 01:14:16PM +0530, Chandan Babu R wrote:
> > > + error = xfs_iext_count_may_overflow(ip, whichfork,
> > > + XFS_IEXT_ADD_CNT);
> >
> > I find the XFS_IEXT_ADD_CNT define very confusing. An explicit 1 passed
> > for a counter parameter makes a lot more sense to me.
>
> The reason to do this was to consolidate the comment descriptions at one
> place. For e.g. the comment for XFS_IEXT_DIR_MANIP_CNT (from "[PATCH V2 05/10]
> xfs: Check for extent overflow when adding/removing dir entries") is slightly
> larger. Using constants (instead of macros) would mean that the same comment
> has to be replicated across the 6 locations it is being used.
I agree with a constant if we have a complex computed value. But a
constant for 1 where it is obvious from the context that one means
the number one as in adding a single items is just silly and really
hurts when reading the code.
>
> --
> chandan
>
>
>
---end quoted text---
next prev parent reply other threads:[~2020-08-27 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:08 [PATCH V2 00/10] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 01/10] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-08-17 6:51 ` Christoph Hellwig
2020-08-17 7:44 ` Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 02/10] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-08-17 6:53 ` Christoph Hellwig
2020-08-17 7:44 ` Chandan Babu R
2020-08-27 8:09 ` Christoph Hellwig [this message]
2020-08-27 13:51 ` Chandan Babu R
2020-08-18 21:49 ` Dave Chinner
2020-08-18 21:57 ` Darrick J. Wong
2020-08-19 4:43 ` Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 03/10] xfs: Check for extent overflow when deleting an extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 04/10] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 05/10] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 06/10] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 07/10] xfs: Check for extent overflow when inserting a hole Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 08/10] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-08-18 22:03 ` Darrick J. Wong
2020-08-19 5:04 ` Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 09/10] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 10/10] xfs: Check for extent overflow when swapping extents Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827080903.GA7605@infradead.org \
--to=hch@infradead.org \
--cc=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox