From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs: initialize the shortform attr header padding entry
Date: Thu, 27 Aug 2020 09:14:26 +0100 [thread overview]
Message-ID: <20200827081426.GD7605@infradead.org> (raw)
In-Reply-To: <1c61a2a6-42aa-55b9-49e3-57541b7dae80@sandeen.net>
On Tue, Aug 25, 2020 at 03:48:13PM -0500, Eric Sandeen wrote:
> On 8/25/20 3:28 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Don't leak kernel memory contents into the shortform attr fork.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> I noticed this too, thanks.
>
> thought I wonder if
>
> a) others lurk and
> b) if we should just be memsetting if_data to zero to avoid the need
> to carefully initialize all of everything always?
>
> Anyway it fixes the problem we noticed so
Yes, I think fully clearing the thing would be better. We can do
a memset for now, but splitting the non-existent data case out of
xfs_idata_realloc into a new helper that does kzmalloc sounds best
long term.
next prev parent reply other threads:[~2020-08-27 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:28 [PATCH] xfs: initialize the shortform attr header padding entry Darrick J. Wong
2020-08-25 20:48 ` Eric Sandeen
2020-08-27 8:14 ` Christoph Hellwig [this message]
2020-08-25 22:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827081426.GD7605@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox