Re: [PATCH 1/4] xfs: Use variable-size array for nameval in xfs_attr_sf_entry

Eric Sandeen
2020-08-31T14:54:59Z

On 8/31/20 9:53 AM, Eric Sandeen wrote:
> On 8/31/20 8:04 AM, Carlos Maiolino wrote:
>> #define XFS_ATTR_SF_ENTSIZE_MAX /* max space for name&value */ \
>> - ((1 << (NBBY*(int)sizeof(uint8_t))) - 1)
>> + (1 << (NBBY*(int)sizeof(uint8_t)))
>
> This probably is not correct. :)
>
> This would cut the max size of attr (name+value) in half.

Whoops other way around. ;) this would double XFS_ATTR_SF_ENTSIZE_MAX.

In any case, just drop that change.

-Eric