From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs.xfs: remove comment about needed future work
Date: Mon, 31 Aug 2020 15:06:12 -0400 [thread overview]
Message-ID: <20200831190612.GB12035@bfoster> (raw)
In-Reply-To: <3a5c9483-954d-e045-7ebe-645250d61efe@sandeen.net>
On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote:
> Remove comment about the need to sync this function with the
> kernel; that was mostly taken care of with:
>
> 7b7548052 ("mkfs: use libxfs to write out new AGs")
>
> There's maybe a little more samey-samey that we could do here,
> but it's not egregiously cut & pasted as it was before.
>
> Signed-off-by: Eric Sandeen <sandeen2redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index a687f385..874e40da 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3418,11 +3418,6 @@ prepare_devices(
>
> }
>
> -/*
> - * XXX: this code is mostly common with the kernel growfs code.
> - * These initialisations should be pulled into libxfs to keep the
> - * kernel/userspace header initialisation code the same.
> - */
> static void
> initialise_ag_headers(
> struct mkfs_params *cfg,
>
next prev parent reply other threads:[~2020-08-31 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 19:37 [PATCH] mkfs.xfs: remove comment about needed future work Eric Sandeen
2020-08-31 19:06 ` Brian Foster [this message]
2020-08-31 19:10 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831190612.GB12035@bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox