* [PATCH] mkfs.xfs: remove comment about needed future work
@ 2020-08-27 19:37 Eric Sandeen
2020-08-31 19:06 ` Brian Foster
2020-08-31 19:10 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2020-08-27 19:37 UTC (permalink / raw)
To: linux-xfs
Remove comment about the need to sync this function with the
kernel; that was mostly taken care of with:
7b7548052 ("mkfs: use libxfs to write out new AGs")
There's maybe a little more samey-samey that we could do here,
but it's not egregiously cut & pasted as it was before.
Signed-off-by: Eric Sandeen <sandeen2redhat.com>
---
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index a687f385..874e40da 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3418,11 +3418,6 @@ prepare_devices(
}
-/*
- * XXX: this code is mostly common with the kernel growfs code.
- * These initialisations should be pulled into libxfs to keep the
- * kernel/userspace header initialisation code the same.
- */
static void
initialise_ag_headers(
struct mkfs_params *cfg,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mkfs.xfs: remove comment about needed future work
2020-08-27 19:37 [PATCH] mkfs.xfs: remove comment about needed future work Eric Sandeen
@ 2020-08-31 19:06 ` Brian Foster
2020-08-31 19:10 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Brian Foster @ 2020-08-31 19:06 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote:
> Remove comment about the need to sync this function with the
> kernel; that was mostly taken care of with:
>
> 7b7548052 ("mkfs: use libxfs to write out new AGs")
>
> There's maybe a little more samey-samey that we could do here,
> but it's not egregiously cut & pasted as it was before.
>
> Signed-off-by: Eric Sandeen <sandeen2redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index a687f385..874e40da 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3418,11 +3418,6 @@ prepare_devices(
>
> }
>
> -/*
> - * XXX: this code is mostly common with the kernel growfs code.
> - * These initialisations should be pulled into libxfs to keep the
> - * kernel/userspace header initialisation code the same.
> - */
> static void
> initialise_ag_headers(
> struct mkfs_params *cfg,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mkfs.xfs: remove comment about needed future work
2020-08-27 19:37 [PATCH] mkfs.xfs: remove comment about needed future work Eric Sandeen
2020-08-31 19:06 ` Brian Foster
@ 2020-08-31 19:10 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-08-31 19:10 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote:
> Remove comment about the need to sync this function with the
> kernel; that was mostly taken care of with:
>
> 7b7548052 ("mkfs: use libxfs to write out new AGs")
>
> There's maybe a little more samey-samey that we could do here,
> but it's not egregiously cut & pasted as it was before.
>
> Signed-off-by: Eric Sandeen <sandeen2redhat.com>
Fixes: 7b7548052d12 ("mkfs: use libxfs to write out new AGs")
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index a687f385..874e40da 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3418,11 +3418,6 @@ prepare_devices(
>
> }
>
> -/*
> - * XXX: this code is mostly common with the kernel growfs code.
> - * These initialisations should be pulled into libxfs to keep the
> - * kernel/userspace header initialisation code the same.
> - */
> static void
> initialise_ag_headers(
> struct mkfs_params *cfg,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-31 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-27 19:37 [PATCH] mkfs.xfs: remove comment about needed future work Eric Sandeen
2020-08-31 19:06 ` Brian Foster
2020-08-31 19:10 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox