From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: RCU stall when using XFS
Date: Tue, 1 Sep 2020 07:36:12 +1000 [thread overview]
Message-ID: <20200831213612.GB12131@dread.disaster.area> (raw)
In-Reply-To: <20200831211915.GB6096@magnolia>
On Mon, Aug 31, 2020 at 02:19:15PM -0700, Darrick J. Wong wrote:
> On Mon, Aug 31, 2020 at 03:22:15PM -0400, Mikulas Patocka wrote:
> > Hi
> >
> > I report this RCU stall when working with one 512GiB file the XFS
> > filesystem on persistent memory. Except for the warning, there was no
> > observed misbehavior.
> >
> > Perhaps, it is missing cond_resched() somewhere.
>
> Yikes, you can send a 2T request to a pmem device??
>
> /sys/block/pmem0/queue/max_hw_sectors_kb : 2147483647
>
> My puny laptop can only push 29GB/s, which I guess means we could stall
> on an IO request for 70 seconds...
This looks like another symptom of the same "bio sizes in writeback
are now unbound if contiguous physical pages are added to them"
problem I raised here when considering a similar hard lockup report
with a 2GB bio:
https://lore.kernel.org/linux-xfs/20200821215358.GG7941@dread.disaster.area/
Quote:
| .e. I'm not looking at this as a "bio overflow bug" - I'm
| commenting on what this overflow implies from an architectural point
| of view. i.e. that uncapped bio sizes and bio chain lengths in
| writeback are actually a bad thing and something we've always
| tried to avoid doing....
This looks like another instance of the same problem...
It really does look like iomap needs to cap the length of ioend and
bio chains...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-08-31 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 19:22 RCU stall when using XFS Mikulas Patocka
2020-08-31 21:19 ` Darrick J. Wong
2020-08-31 21:36 ` Dave Chinner [this message]
2020-09-01 0:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831213612.GB12131@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox