From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files
Date: Wed, 2 Sep 2020 10:38:42 -0700 [thread overview]
Message-ID: <20200902173842.GT6096@magnolia> (raw)
In-Reply-To: <20200902164012.GN6096@magnolia>
On Wed, Sep 02, 2020 at 09:40:12AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The realtime flag only applies to the data fork, so don't use the
> realtime block number checks on the attr fork of a realtime file.
>
> Fixes: 30b0984d9117 ("xfs: refactor bmap record validation")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
NAK, I should've sent this from my stable tree, not my dev tree.
--D
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index ce2e702b6b43..d35250c9bb07 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -6310,7 +6310,7 @@ xfs_bmap_validate_extent_raw(
> xfs_fsblock_t endfsb;
>
> endfsb = irec->br_startblock + irec->br_blockcount - 1;
> - if (isrt) {
> + if (isrt && whichfork == XFS_DATA_FORK) {
> if (!xfs_verify_rtbno(mp, irec->br_startblock))
> return __this_address;
> if (!xfs_verify_rtbno(mp, endfsb))
prev parent reply other threads:[~2020-09-02 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:40 [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files Darrick J. Wong
2020-09-02 17:38 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902173842.GT6096@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox