* [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files
@ 2020-09-02 16:40 Darrick J. Wong
2020-09-02 17:38 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-09-02 16:40 UTC (permalink / raw)
To: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
The realtime flag only applies to the data fork, so don't use the
realtime block number checks on the attr fork of a realtime file.
Fixes: 30b0984d9117 ("xfs: refactor bmap record validation")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_bmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index ce2e702b6b43..d35250c9bb07 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -6310,7 +6310,7 @@ xfs_bmap_validate_extent_raw(
xfs_fsblock_t endfsb;
endfsb = irec->br_startblock + irec->br_blockcount - 1;
- if (isrt) {
+ if (isrt && whichfork == XFS_DATA_FORK) {
if (!xfs_verify_rtbno(mp, irec->br_startblock))
return __this_address;
if (!xfs_verify_rtbno(mp, endfsb))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files
2020-09-02 16:40 [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files Darrick J. Wong
@ 2020-09-02 17:38 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-09-02 17:38 UTC (permalink / raw)
To: xfs
On Wed, Sep 02, 2020 at 09:40:12AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The realtime flag only applies to the data fork, so don't use the
> realtime block number checks on the attr fork of a realtime file.
>
> Fixes: 30b0984d9117 ("xfs: refactor bmap record validation")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
NAK, I should've sent this from my stable tree, not my dev tree.
--D
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index ce2e702b6b43..d35250c9bb07 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -6310,7 +6310,7 @@ xfs_bmap_validate_extent_raw(
> xfs_fsblock_t endfsb;
>
> endfsb = irec->br_startblock + irec->br_blockcount - 1;
> - if (isrt) {
> + if (isrt && whichfork == XFS_DATA_FORK) {
> if (!xfs_verify_rtbno(mp, irec->br_startblock))
> return __this_address;
> if (!xfs_verify_rtbno(mp, endfsb))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-02 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-02 16:40 [PATCH] xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files Darrick J. Wong
2020-09-02 17:38 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox