From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2 3/4] xfs: Use variable-size array for nameval in xfs_attr_sf_entry
Date: Thu, 3 Sep 2020 10:11:40 +0100 [thread overview]
Message-ID: <20200903091140.GC10584@infradead.org> (raw)
In-Reply-To: <20200902144059.284726-4-cmaiolino@redhat.com>
On Wed, Sep 02, 2020 at 04:40:58PM +0200, Carlos Maiolino wrote:
> nameval is a variable-size array, so, define it as it, and remove all
> the -1 magic number subtractions
Looks good, but two little style nitpicks below.
Reviewed-by: Christoph Hellwig <hch@lst.de>
> if (be16_to_cpu(name_loc->valuelen) >= XFS_ATTR_SF_ENTSIZE_MAX)
> return 0;
> - bytes += sizeof(struct xfs_attr_sf_entry) - 1
> + bytes += sizeof(struct xfs_attr_sf_entry)
> + name_loc->namelen
> + be16_to_cpu(name_loc->valuelen);
This can be condensed to:
bytes += sizeof(struct xfs_attr_sf_entry) + name_loc->namelen +
be16_to_cpu(name_loc->valuelen);
> index c4afb33079184..f608a2966d7f8 100644
> --- a/fs/xfs/libxfs/xfs_attr_sf.h
> +++ b/fs/xfs/libxfs/xfs_attr_sf.h
> @@ -27,11 +27,11 @@ typedef struct xfs_attr_sf_sort {
> } xfs_attr_sf_sort_t;
>
> #define XFS_ATTR_SF_ENTSIZE_BYNAME(nlen,vlen) /* space name/value uses */ \
> - (((int)sizeof(struct xfs_attr_sf_entry)-1 + (nlen)+(vlen)))
> + (((int)sizeof(struct xfs_attr_sf_entry) + (nlen)+(vlen)))
We can drop the int cast, but more importantly please add whitespaces
before and after the + operator.
next prev parent reply other threads:[~2020-09-03 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 14:40 [PATCH 0/4 V2] Clean up xfs_attr_sf_entry Carlos Maiolino
2020-09-02 14:40 ` [PATCH V2 1/4] xfs: remove typedef xfs_attr_sf_entry_t Carlos Maiolino
2020-09-02 17:35 ` Darrick J. Wong
2020-09-03 8:52 ` Christoph Hellwig
2020-09-02 14:40 ` [PATCH V2 2/4] xfs: Remove typedef xfs_attr_shortform_t Carlos Maiolino
2020-09-02 17:36 ` Darrick J. Wong
2020-09-03 8:28 ` Carlos Maiolino
2020-09-03 8:53 ` Christoph Hellwig
2020-09-02 14:40 ` [PATCH V2 3/4] xfs: Use variable-size array for nameval in xfs_attr_sf_entry Carlos Maiolino
2020-09-02 17:52 ` Darrick J. Wong
2020-09-03 9:11 ` Christoph Hellwig [this message]
2020-09-02 14:40 ` [PATCH V2 4/4] xfs: Convert xfs_attr_sf macros to inline functions Carlos Maiolino
2020-09-02 17:54 ` Darrick J. Wong
2020-09-03 10:36 ` Carlos Maiolino
2020-09-03 9:14 ` Christoph Hellwig
2020-09-03 10:38 ` Carlos Maiolino
2020-09-03 10:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903091140.GC10584@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox