From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev
Date: Tue, 8 Sep 2020 15:56:14 +0100 [thread overview]
Message-ID: <20200908145614.GL6039@infradead.org> (raw)
In-Reply-To: <159950166858.582172.16284988680675778406.stgit@magnolia>
On Mon, Sep 07, 2020 at 11:01:08AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> While running generic/042 with -drtinherit=1 set in MKFS_OPTIONS, I
> observed that the kernel will gladly set the realtime flag on any file
> created on the loopback filesystem even though that filesystem doesn't
> actually have a realtime device attached. This leads to verifier
> failures and doesn't make any sense, so be smarter about this.
Looks good, but add an overly long line. Which just suggested that
the whole flag inheritance really needs to be split into a helper..
next prev parent reply other threads:[~2020-09-08 19:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 18:01 [PATCH 0/3] xfs: fix a few realtime bugs Darrick J. Wong
2020-09-07 18:01 ` [PATCH 1/3] xfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev Darrick J. Wong
2020-09-08 14:56 ` Christoph Hellwig [this message]
2020-09-07 18:01 ` [PATCH 2/3] xfs: make sure the rt allocator doesn't run off the end Darrick J. Wong
2020-09-08 14:58 ` Christoph Hellwig
2020-09-07 18:01 ` [PATCH 3/3] xfs: ensure that fpunch, fcollapse, and finsert operations are aligned to rt extent size Darrick J. Wong
2020-09-08 14:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908145614.GL6039@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox