From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: make sure the rt allocator doesn't run off the end
Date: Tue, 8 Sep 2020 15:58:20 +0100 [thread overview]
Message-ID: <20200908145820.GM6039@infradead.org> (raw)
In-Reply-To: <159950167474.582172.16930353017934744381.stgit@magnolia>
On Mon, Sep 07, 2020 at 11:01:14AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> There's an overflow bug in the realtime allocator. If the rt volume is
> large enough to handle a single allocation request that is larger than
> the maximum bmap extent length and the rt bitmap ends exactly on a
> bitmap block boundary, it's possible that the near allocator will try to
> check the freeness of a range that extends past the end of the bitmap.
> This fails with a corruption error and shuts down the fs.
>
> Therefore, constrain maxlen so that the range scan cannot run off the
> end of the rt bitmap.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-08 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 18:01 [PATCH 0/3] xfs: fix a few realtime bugs Darrick J. Wong
2020-09-07 18:01 ` [PATCH 1/3] xfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev Darrick J. Wong
2020-09-08 14:56 ` Christoph Hellwig
2020-09-07 18:01 ` [PATCH 2/3] xfs: make sure the rt allocator doesn't run off the end Darrick J. Wong
2020-09-08 14:58 ` Christoph Hellwig [this message]
2020-09-07 18:01 ` [PATCH 3/3] xfs: ensure that fpunch, fcollapse, and finsert operations are aligned to rt extent size Darrick J. Wong
2020-09-08 14:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908145820.GM6039@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox