* [PATCH -next] xfs: Remove unneeded semicolon
@ 2020-09-09 12:07 Zheng Bin
2020-09-09 18:52 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Bin @ 2020-09-09 12:07 UTC (permalink / raw)
To: darrick.wong, linux-xfs, linux-kernel; +Cc: yi.zhang, zhengbin13
Fixes coccicheck warning:
fs/xfs/xfs_icache.c:1214:2-3: Unneeded semicolon
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
fs/xfs/xfs_icache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 101028ebb571..5e926912e507 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -1211,7 +1211,7 @@ xfs_reclaim_inodes(
while (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
xfs_ail_push_all_sync(mp->m_ail);
xfs_reclaim_inodes_ag(mp, &nr_to_scan);
- };
+ }
}
/*
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] xfs: Remove unneeded semicolon
2020-09-09 12:07 [PATCH -next] xfs: Remove unneeded semicolon Zheng Bin
@ 2020-09-09 18:52 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2020-09-09 18:52 UTC (permalink / raw)
To: Zheng Bin; +Cc: linux-xfs, linux-kernel, yi.zhang
On Wed, Sep 09, 2020 at 08:07:32PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> fs/xfs/xfs_icache.c:1214:2-3: Unneeded semicolon
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_icache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 101028ebb571..5e926912e507 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -1211,7 +1211,7 @@ xfs_reclaim_inodes(
> while (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
> xfs_ail_push_all_sync(mp->m_ail);
> xfs_reclaim_inodes_ag(mp, &nr_to_scan);
> - };
> + }
> }
>
> /*
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] xfs: Remove unneeded semicolon
@ 2023-07-03 1:21 Yang Li
2023-07-03 3:50 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Yang Li @ 2023-07-03 1:21 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, linux-kernel, Yang Li, Abaci Robot
./fs/xfs/xfs_extfree_item.c:723:3-4: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5728
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/xfs/xfs_extfree_item.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
index cdd8ebb6e7cb..f1a5ecf099aa 100644
--- a/fs/xfs/xfs_extfree_item.c
+++ b/fs/xfs/xfs_extfree_item.c
@@ -720,7 +720,7 @@ xfs_efi_item_recover(
requeue_only = true;
continue;
}
- };
+ }
if (error == -EFSCORRUPTED)
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xfs: Remove unneeded semicolon
2023-07-03 1:21 Yang Li
@ 2023-07-03 3:50 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2023-07-03 3:50 UTC (permalink / raw)
To: Yang Li; +Cc: linux-xfs, linux-kernel, Abaci Robot
On Mon, Jul 03, 2023 at 09:21:31AM +0800, Yang Li wrote:
> ./fs/xfs/xfs_extfree_item.c:723:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5728
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/xfs/xfs_extfree_item.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
> index cdd8ebb6e7cb..f1a5ecf099aa 100644
> --- a/fs/xfs/xfs_extfree_item.c
> +++ b/fs/xfs/xfs_extfree_item.c
> @@ -720,7 +720,7 @@ xfs_efi_item_recover(
> requeue_only = true;
> continue;
> }
> - };
> + }
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> if (error == -EFSCORRUPTED)
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-03 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-09 12:07 [PATCH -next] xfs: Remove unneeded semicolon Zheng Bin
2020-09-09 18:52 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-07-03 1:21 Yang Li
2023-07-03 3:50 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox