From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 1/2] xfs: refactor inode flags propagation code
Date: Thu, 10 Sep 2020 06:42:32 +0100 [thread overview]
Message-ID: <20200910054232.GA7379@infradead.org> (raw)
In-Reply-To: <159971621055.1311472.9677034380244876371.stgit@magnolia>
> + if (pip && (pip->i_d.di_flags & XFS_DIFLAG_ANY))
> + xfs_inode_propagate_flags(ip, pip);
> + if (pip && (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY))
> + xfs_inode_propagate_flags2(ip, pip);
I'd further simplify this to:
if (pip) {
if (pip->i_d.di_flags & XFS_DIFLAG_ANY)
xfs_inode_propagate_flags(ip, pip);
if (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY)
xfs_inode_propagate_flags2(ip, pip);
}
and maybe use "inherit" instead of "propagate"
But otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-10 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 5:36 [PATCH v2 0/2] xfs: fix a few realtime bugs Darrick J. Wong
2020-09-10 5:36 ` [PATCH 1/2] xfs: refactor inode flags propagation code Darrick J. Wong
2020-09-10 5:42 ` Christoph Hellwig [this message]
2020-09-10 5:36 ` [PATCH 2/2] xfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev Darrick J. Wong
2020-09-10 5:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910054232.GA7379@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox