From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FFCC433E2 for ; Thu, 17 Sep 2020 05:28:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F072078D for ; Thu, 17 Sep 2020 05:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="YNVqNBug" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgIQF25 (ORCPT ); Thu, 17 Sep 2020 01:28:57 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53090 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgIQF25 (ORCPT ); Thu, 17 Sep 2020 01:28:57 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GLP5pa189918; Wed, 16 Sep 2020 21:30:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=vkeP0fpc6pnjp5/dkneZcYB+ekM+SUTJyvdjjsUzTaA=; b=YNVqNBugnauPHB77Eem8/wvwhSZXDzv6QuLFYe+WrOj5GKCX32Sl4V7Hn1yI3ZKU4wUl yJNVcQMMLuAV84g+m2GKPXX00we/FKMcrR346+xyxQ5KzW5zstmhwZBajcU+Ccqne21Q Ocfdl2TNL2Rhw2MfLJz6tv8PoFKnhgRTqTBYc/bZjr2zS8GYgXU5NMDaWVQHJIgrT2na b/R7S1Zp/PbzOWQYtd0WHYIWruJC7Pc4REs7wW8Kf6Ic6Xer1RGN/B8t/yC+njFMot/l ZFtrNnKngOCSgReXt1kU6SpxOv5KdGm9JpS/XGqlpZrJrU9tKPyZiVUvM4Z0yeqmfxmL Lw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 33gp9mdkut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Sep 2020 21:30:14 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GLPWmU037249; Wed, 16 Sep 2020 21:30:13 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 33h889bpg1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Sep 2020 21:30:13 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08GLUDsl003264; Wed, 16 Sep 2020 21:30:13 GMT Received: from localhost (/10.159.158.133) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 Sep 2020 21:30:12 +0000 Date: Wed, 16 Sep 2020 14:30:11 -0700 From: "Darrick J. Wong" To: xiakaixu1987@gmail.com Cc: linux-xfs@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] xfs: remove the unnecessary xfs_dqid_t type cast Message-ID: <20200916213011.GM7955@magnolia> References: <1600255152-16086-1-git-send-email-kaixuxia@tencent.com> <1600255152-16086-4-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600255152-16086-4-git-send-email-kaixuxia@tencent.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=3 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160156 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=3 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160156 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org n Wed, Sep 16, 2020 at 07:19:06PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > Since the type prid_t and xfs_dqid_t both are uint32_t, seems the > type cast is unnecessary, so remove it. > > Signed-off-by: Kaixu Xia Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_qm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index 3f82e0c92c2d..41a459ffd1f2 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -1715,7 +1715,7 @@ xfs_qm_vop_dqalloc( > if ((flags & XFS_QMOPT_PQUOTA) && XFS_IS_PQUOTA_ON(mp)) { > if (ip->i_d.di_projid != prid) { > xfs_iunlock(ip, lockflags); > - error = xfs_qm_dqget(mp, (xfs_dqid_t)prid, > + error = xfs_qm_dqget(mp, prid, > XFS_DQTYPE_PROJ, true, &pq); > if (error) { > ASSERT(error != -ENOENT); > -- > 2.20.0 >