Re: [PATCH] xfs: fix some comments

Darrick J. Wong
2020-09-17T01:14:45Z

On Wed, Sep 16, 2020 at 07:19:12PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the comments to help people understand the code.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_da_format.h | 4 ++--
> fs/xfs/xfs_dquot.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_da_format.h b/fs/xfs/libxfs/xfs_da_format.h
> index 4fe974773d85..b58943f2eb41 100644
> --- a/fs/xfs/libxfs/xfs_da_format.h
> +++ b/fs/xfs/libxfs/xfs_da_format.h
> @@ -35,8 +35,8 @@ typedef struct xfs_da_blkinfo {
> */
> #define XFS_DA3_NODE_MAGIC 0x3ebe /* magic number: non-leaf blocks */
> #define XFS_ATTR3_LEAF_MAGIC 0x3bee /* magic number: attribute leaf blks */
> -#define XFS_DIR3_LEAF1_MAGIC 0x3df1 /* magic number: v2 dirlf single blks */
> -#define XFS_DIR3_LEAFN_MAGIC 0x3dff /* magic number: v2 dirlf multi blks */
> +#define XFS_DIR3_LEAF1_MAGIC 0x3df1 /* magic number: v3 dirlf single blks */
> +#define XFS_DIR3_LEAFN_MAGIC 0x3dff /* magic number: v3 dirlf multi blks */
>
> struct xfs_da3_blkinfo {
> /*
> diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
> index 3072814e407d..1d95ed387d66 100644
> --- a/fs/xfs/xfs_dquot.c
> +++ b/fs/xfs/xfs_dquot.c
> @@ -831,8 +831,8 @@ xfs_qm_dqget_checks(
> }
>
> /*
> - * Given the file system, id, and type (UDQUOT/GDQUOT), return a locked
> - * dquot, doing an allocation (if requested) as needed.
> + * Given the file system, id, and type (UDQUOT/GDQUOT/PDQUOT), return a
> + * locked dquot, doing an allocation (if requested) as needed.
> */
> int
> xfs_qm_dqget(
> --
> 2.20.0
>