From: Christoph Hellwig <hch@infradead.org>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] mkfs.xfs: fix ASSERT on too-small device with stripe geometry
Date: Thu, 17 Sep 2020 09:10:05 +0100 [thread overview]
Message-ID: <20200917081005.GC26262@infradead.org> (raw)
In-Reply-To: <20200916204056.29247-1-preichl@redhat.com>
On Wed, Sep 16, 2020 at 10:40:56PM +0200, Pavel Reichl wrote:
> When a too-small device is created with stripe geometry, we hit an
> assert in align_ag_geometry():
>
> mkfs.xfs: xfs_mkfs.c:2834: align_ag_geometry: Assertion `cfg->agcount != 0' failed.
>
> This is because align_ag_geometry() finds that the size of the last
> (only) AG is too small, and attempts to trim it off. Obviously 0
> AGs is invalid, and we hit the ASSERT.
>
> Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
> Suggested-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-17 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 20:40 [PATCH v2] mkfs.xfs: fix ASSERT on too-small device with stripe geometry Pavel Reichl
2020-09-17 8:10 ` Christoph Hellwig [this message]
2020-09-23 7:53 ` Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2020-09-14 18:26 [PATCH] " Eric Sandeen
2020-09-14 19:00 ` [PATCH V2] " Eric Sandeen
2020-09-14 19:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917081005.GC26262@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox