From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: check dabtree node hash values when loading child blocks
Date: Thu, 17 Sep 2020 09:12:05 +0100 [thread overview]
Message-ID: <20200917081205.GE26262@infradead.org> (raw)
In-Reply-To: <160031331944.3624286.5979437788459484830.stgit@magnolia>
On Wed, Sep 16, 2020 at 08:28:39PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When xchk_da_btree_block is loading a non-root dabtree block, we know
> that the parent block had to have a (hashval, address) pointer to the
> block that we just loaded. Check that the hashval in the parent matches
> the block we just loaded.
>
> This was found by fuzzing nbtree[3].hashval = ones in xfs/394.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-09-17 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:28 [PATCH 0/2] xfs: random fixes Darrick J. Wong
2020-09-17 3:28 ` [PATCH 1/2] xfs: don't free rt blocks when we're doing a REMAP bunmapi call Darrick J. Wong
2020-09-17 4:43 ` Dave Chinner
2020-09-17 8:11 ` Christoph Hellwig
2020-09-17 17:42 ` Darrick J. Wong
2020-09-18 2:14 ` [PATCH v2 " Darrick J. Wong
2020-09-19 5:14 ` Christoph Hellwig
2020-09-21 6:51 ` Dave Chinner
2020-09-17 3:28 ` [PATCH 2/2] xfs: check dabtree node hash values when loading child blocks Darrick J. Wong
2020-09-17 4:48 ` Dave Chinner
2020-09-17 8:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917081205.GE26262@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox