Re: [PATCH v3 3/2] xfs: don't release log intent items when recovery fails

Christoph Hellwig
2020-09-19T05:49:33Z

On Thu, Sep 17, 2020 at 07:19:40PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Nowadays, log recovery will call ->release on the recovered intent items
> if recovery fails. Therefore, it's redundant to release them from
> inside the ->recover functions when they're about to return an error.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v3: fix subject line
> v2: log recovery frees unfinished intent items on failure, so remove
> release calls

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

I'm actually pretty sure I have the same patch lingering in one my
unfinished branches somewhere..