public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] libxfs: refactor inode flags propagation code
Date: Thu, 17 Sep 2020 09:22:30 -0700	[thread overview]
Message-ID: <20200917162230.GD7955@magnolia> (raw)
In-Reply-To: <20200917080159.GT26262@infradead.org>

On Thu, Sep 17, 2020 at 09:01:59AM +0100, Christoph Hellwig wrote:
> On Mon, Sep 14, 2020 at 06:51:11PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Hoist the code that propagates di_flags from a parent to a new child
> > into a separate function.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Looks good (except for the fact that this is duplicated and not shared
> with the kernel..)

Yeah, I'm working towards that:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=inode-refactor

and

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=inode-refactor

--D

> Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2020-09-17 16:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  1:51 [PATCH 0/4] xfsprogs: even more fixes for 5.9 Darrick J. Wong
2020-09-15  1:51 ` [PATCH 1/4] libxfs: refactor inode flags propagation code Darrick J. Wong
2020-09-17  8:01   ` Christoph Hellwig
2020-09-17 16:22     ` Darrick J. Wong [this message]
2020-09-15  1:51 ` [PATCH 2/4] libxfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev Darrick J. Wong
2020-09-17  8:02   ` Christoph Hellwig
2020-09-28 21:26   ` Eric Sandeen
2020-09-15  1:51 ` [PATCH 3/4] mkfs: don't allow creation of realtime files from a proto file Darrick J. Wong
2020-09-17  8:02   ` Christoph Hellwig
2020-09-17 16:25     ` Darrick J. Wong
2020-09-28 21:10   ` Eric Sandeen
2020-09-15  1:51 ` [PATCH 4/4] xfs_repair: don't flag RTINHERIT files when no rt volume Darrick J. Wong
2020-09-17  8:02   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917162230.GD7955@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox