From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A09C43461 for ; Thu, 17 Sep 2020 16:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2638206E6 for ; Thu, 17 Sep 2020 16:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="pcbPbRwP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbgIQQWz (ORCPT ); Thu, 17 Sep 2020 12:22:55 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34596 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728467AbgIQQWn (ORCPT ); Thu, 17 Sep 2020 12:22:43 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HGL4oD182969; Thu, 17 Sep 2020 16:22:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=/4p8Y+V/OF0vC8M6mf7vaIZY9CytJzXe614kpGVId9A=; b=pcbPbRwPiLKoLNz9c5S+sgG7/pGEWXr/m+E9nQ3EouB4qCQrtdJSDISMCcpDG+pmC8ju QPFh+smO9+imzs+b2OGWTJs9m+uh80KquIOMyopBcLtsRxor8ckuYyaJ8Lyaa6TFHpI5 jXCvQolxHdH2/kn6IISwF33TLR3iJMRqgh08WRZjWkvMVNW0iTlWaom34wDg9IhExXyt k9A+C2PYzB5HOc5xkZJLu6pTlpPBDgm5V09zUV6QKiuqf4PFkJTt2vTiEQk7QReBLuQI UkiFAdUmsiwZzdYmQgV8wyVG7NLg+2DjFv7dKvaJn8k3Wi603mFhc7H9I74FxgZdxrfF DA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 33gp9mjawv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 16:22:33 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HGFwfk187384; Thu, 17 Sep 2020 16:22:32 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 33hm354rgy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2020 16:22:32 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08HGMVJ0030809; Thu, 17 Sep 2020 16:22:31 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Sep 2020 16:22:31 +0000 Date: Thu, 17 Sep 2020 09:22:30 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/4] libxfs: refactor inode flags propagation code Message-ID: <20200917162230.GD7955@magnolia> References: <160013466518.2932378.9536364695832878473.stgit@magnolia> <160013467138.2932378.13730720108241920821.stgit@magnolia> <20200917080159.GT26262@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917080159.GT26262@infradead.org> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170123 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170123 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Sep 17, 2020 at 09:01:59AM +0100, Christoph Hellwig wrote: > On Mon, Sep 14, 2020 at 06:51:11PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Hoist the code that propagates di_flags from a parent to a new child > > into a separate function. > > > > Signed-off-by: Darrick J. Wong > > Looks good (except for the fact that this is duplicated and not shared > with the kernel..) Yeah, I'm working towards that: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=inode-refactor and https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=inode-refactor --D > Reviewed-by: Christoph Hellwig