From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 1/2] xfs: don't free rt blocks when we're doing a REMAP bunmapi call
Date: Mon, 21 Sep 2020 16:51:16 +1000 [thread overview]
Message-ID: <20200921065116.GN12131@dread.disaster.area> (raw)
In-Reply-To: <20200918021450.GU7955@magnolia>
On Thu, Sep 17, 2020 at 07:14:50PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When callers pass XFS_BMAPI_REMAP into xfs_bunmapi, they want the extent
> to be unmapped from the given file fork without the extent being freed.
> We do this for non-rt files, but we forgot to do this for realtime
> files. So far this isn't a big deal since nobody makes a bunmapi call
> to a rt file with the REMAP flag set, but don't leave a logic bomb.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v2: only compute bno if we're going to use it
> ---
> fs/xfs/libxfs/xfs_bmap.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-09-21 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:28 [PATCH 0/2] xfs: random fixes Darrick J. Wong
2020-09-17 3:28 ` [PATCH 1/2] xfs: don't free rt blocks when we're doing a REMAP bunmapi call Darrick J. Wong
2020-09-17 4:43 ` Dave Chinner
2020-09-17 8:11 ` Christoph Hellwig
2020-09-17 17:42 ` Darrick J. Wong
2020-09-18 2:14 ` [PATCH v2 " Darrick J. Wong
2020-09-19 5:14 ` Christoph Hellwig
2020-09-21 6:51 ` Dave Chinner [this message]
2020-09-17 3:28 ` [PATCH 2/2] xfs: check dabtree node hash values when loading child blocks Darrick J. Wong
2020-09-17 4:48 ` Dave Chinner
2020-09-17 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921065116.GN12131@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox