From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH 2/3] xfs: remove the unused parameter id from xfs_qm_dqattach_one
Date: Tue, 22 Sep 2020 09:20:00 -0700 [thread overview]
Message-ID: <20200922162000.GJ7955@magnolia> (raw)
In-Reply-To: <1600765442-12146-3-git-send-email-kaixuxia@tencent.com>
On Tue, Sep 22, 2020 at 05:04:01PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Since we never use the second parameter id, so remove it from
> xfs_qm_dqattach_one() function.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Heh, yep.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_qm.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 41a459ffd1f2..44509decb4cd 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -249,7 +249,6 @@ xfs_qm_unmount_quotas(
> STATIC int
> xfs_qm_dqattach_one(
> struct xfs_inode *ip,
> - xfs_dqid_t id,
> xfs_dqtype_t type,
> bool doalloc,
> struct xfs_dquot **IO_idqpp)
> @@ -330,23 +329,23 @@ xfs_qm_dqattach_locked(
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
>
> if (XFS_IS_UQUOTA_ON(mp) && !ip->i_udquot) {
> - error = xfs_qm_dqattach_one(ip, i_uid_read(VFS_I(ip)),
> - XFS_DQTYPE_USER, doalloc, &ip->i_udquot);
> + error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_USER,
> + doalloc, &ip->i_udquot);
> if (error)
> goto done;
> ASSERT(ip->i_udquot);
> }
>
> if (XFS_IS_GQUOTA_ON(mp) && !ip->i_gdquot) {
> - error = xfs_qm_dqattach_one(ip, i_gid_read(VFS_I(ip)),
> - XFS_DQTYPE_GROUP, doalloc, &ip->i_gdquot);
> + error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_GROUP,
> + doalloc, &ip->i_gdquot);
> if (error)
> goto done;
> ASSERT(ip->i_gdquot);
> }
>
> if (XFS_IS_PQUOTA_ON(mp) && !ip->i_pdquot) {
> - error = xfs_qm_dqattach_one(ip, ip->i_d.di_projid, XFS_DQTYPE_PROJ,
> + error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_PROJ,
> doalloc, &ip->i_pdquot);
> if (error)
> goto done;
> --
> 2.20.0
>
next prev parent reply other threads:[~2020-09-22 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 9:03 [RFC PATCH 0/3]xfs: random fixes for disk quota xiakaixu1987
2020-09-22 9:04 ` [PATCH 1/3] xfs: directly return if the delta equal to zero xiakaixu1987
2020-09-22 16:19 ` Darrick J. Wong
2020-09-22 17:43 ` Brian Foster
2020-09-23 2:42 ` kaixuxia
2020-09-23 13:27 ` Brian Foster
2020-09-23 16:09 ` Darrick J. Wong
2020-09-23 7:01 ` Christoph Hellwig
2020-09-22 9:04 ` [PATCH 2/3] xfs: remove the unused parameter id from xfs_qm_dqattach_one xiakaixu1987
2020-09-22 16:20 ` Darrick J. Wong [this message]
2020-09-23 7:02 ` Christoph Hellwig
2020-09-22 9:04 ` [PATCH 3/3] xfs: only do dqget or dqhold for the specified dquots xiakaixu1987
2020-09-22 16:18 ` Darrick J. Wong
2020-09-23 3:11 ` kaixuxia
2020-09-23 16:30 ` [RFC PATCH 0/3]xfs: random fixes for disk quota Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922162000.GJ7955@magnolia \
--to=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox