From: Christoph Hellwig <hch@infradead.org>
To: Gao Xiang <hsiangkao@aol.com>
Cc: linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Gao Xiang <hsiangkao@redhat.com>
Subject: Re: [PATCH] xfs: drop the obsolete comment on filestream locking
Date: Wed, 23 Sep 2020 08:05:43 +0100 [thread overview]
Message-ID: <20200923070543.GC25798@infradead.org> (raw)
In-Reply-To: <20200922034249.20549-1-hsiangkao@aol.com>
On Tue, Sep 22, 2020 at 11:42:49AM +0800, Gao Xiang wrote:
> From: Gao Xiang <hsiangkao@redhat.com>
>
> Since commit 1c1c6ebcf52 ("xfs: Replace per-ag array with a radix
> tree"), there is no m_peraglock anymore, so it's hard to understand
> the described situation since per-ag is no longer an array and no
> need to reallocate, call xfs_filestream_flush() in growfs.
>
> In addition, the race condition for shrink feature is quite confusing
> to me currently as well. Get rid of it instead.
>
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
Yes, this is all very outdated with the removal of the realloced
ag array:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-23 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200922034249.20549-1-hsiangkao.ref@aol.com>
2020-09-22 3:42 ` [PATCH] xfs: drop the obsolete comment on filestream locking Gao Xiang
2020-09-22 4:44 ` Gao Xiang
2020-09-22 16:03 ` Darrick J. Wong
2020-09-22 16:23 ` Gao Xiang
2020-09-22 16:40 ` Darrick J. Wong
2020-09-22 21:26 ` Dave Chinner
2020-09-23 0:21 ` Gao Xiang
2020-09-23 7:05 ` Christoph Hellwig [this message]
2020-09-23 16:27 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923070543.GC25798@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hsiangkao@aol.com \
--cc=hsiangkao@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox