From: Christoph Hellwig <hch@infradead.org>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v3 6/7] xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local}
Date: Wed, 23 Sep 2020 08:08:11 +0100 [thread overview]
Message-ID: <20200923070811.GD25798@infradead.org> (raw)
In-Reply-To: <1600844358-16601-7-git-send-email-kaixuxia@tencent.com>
On Wed, Sep 23, 2020 at 02:59:17PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Cleanup the typedef usage, the unnecessary parentheses, the unnecessary
> backslash and use the open-coded round_up call in
> xfs_attr_leaf_entsize_{remote,local}.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-23 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 6:59 [PATCH v3 0/7] xfs: random fixes and code cleanup xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 1/7] xfs: remove the unused SYNCHRONIZE macro xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 2/7] xfs: use the existing type definition for di_projid xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 3/7] xfs: remove the unnecessary xfs_dqid_t type cast xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 4/7] xfs: do the assert for all the log done items in xfs_trans_cancel xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 5/7] xfs: remove the redundant crc feature check in xfs_attr3_rmt_verify xiakaixu1987
2020-09-23 6:59 ` [PATCH v3 6/7] xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local} xiakaixu1987
2020-09-23 7:08 ` Christoph Hellwig [this message]
2020-09-23 6:59 ` [PATCH v3 7/7] xfs: fix some comments xiakaixu1987
2020-09-23 16:28 ` [PATCH v3 0/7] xfs: random fixes and code cleanup Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923070811.GD25798@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox