* [RFC PATCH] xfs: directly call xfs_generic_create() for ->create() and ->mkdir()
@ 2020-09-24 14:30 xiakaixu1987
2020-09-24 15:08 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: xiakaixu1987 @ 2020-09-24 14:30 UTC (permalink / raw)
To: linux-xfs; +Cc: darrick.wong, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The current create and mkdir handlers both call the xfs_vn_mknod()
which is a wrapper routine around xfs_generic_create() function.
Actually the create and mkdir handlers can directly call
xfs_generic_create() function and reduce the call chain.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
fs/xfs/xfs_iops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 80a13c8561d8..b29d5b25634c 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -237,7 +237,7 @@ xfs_vn_create(
umode_t mode,
bool flags)
{
- return xfs_vn_mknod(dir, dentry, mode, 0);
+ return xfs_generic_create(dir, dentry, mode, 0, false);
}
STATIC int
@@ -246,7 +246,7 @@ xfs_vn_mkdir(
struct dentry *dentry,
umode_t mode)
{
- return xfs_vn_mknod(dir, dentry, mode|S_IFDIR, 0);
+ return xfs_generic_create(dir, dentry, mode|S_IFDIR, 0, false);
}
STATIC struct dentry *
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] xfs: directly call xfs_generic_create() for ->create() and ->mkdir()
2020-09-24 14:30 [RFC PATCH] xfs: directly call xfs_generic_create() for ->create() and ->mkdir() xiakaixu1987
@ 2020-09-24 15:08 ` Darrick J. Wong
2020-09-25 2:31 ` kaixuxia
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2020-09-24 15:08 UTC (permalink / raw)
To: xiakaixu1987; +Cc: linux-xfs, Kaixu Xia
On Thu, Sep 24, 2020 at 10:30:17PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The current create and mkdir handlers both call the xfs_vn_mknod()
> which is a wrapper routine around xfs_generic_create() function.
> Actually the create and mkdir handlers can directly call
> xfs_generic_create() function and reduce the call chain.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> fs/xfs/xfs_iops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 80a13c8561d8..b29d5b25634c 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -237,7 +237,7 @@ xfs_vn_create(
> umode_t mode,
> bool flags)
> {
> - return xfs_vn_mknod(dir, dentry, mode, 0);
> + return xfs_generic_create(dir, dentry, mode, 0, false);
> }
>
> STATIC int
> @@ -246,7 +246,7 @@ xfs_vn_mkdir(
> struct dentry *dentry,
> umode_t mode)
> {
> - return xfs_vn_mknod(dir, dentry, mode|S_IFDIR, 0);
> + return xfs_generic_create(dir, dentry, mode|S_IFDIR, 0, false);
Might as well separate mode, the pipe, and S_IFDIR with a space...
--D
> }
>
> STATIC struct dentry *
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] xfs: directly call xfs_generic_create() for ->create() and ->mkdir()
2020-09-24 15:08 ` Darrick J. Wong
@ 2020-09-25 2:31 ` kaixuxia
0 siblings, 0 replies; 3+ messages in thread
From: kaixuxia @ 2020-09-25 2:31 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, Kaixu Xia
On 2020/9/24 23:08, Darrick J. Wong wrote:
> On Thu, Sep 24, 2020 at 10:30:17PM +0800, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> The current create and mkdir handlers both call the xfs_vn_mknod()
>> which is a wrapper routine around xfs_generic_create() function.
>> Actually the create and mkdir handlers can directly call
>> xfs_generic_create() function and reduce the call chain.
>>
>> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>> ---
>> fs/xfs/xfs_iops.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
>> index 80a13c8561d8..b29d5b25634c 100644
>> --- a/fs/xfs/xfs_iops.c
>> +++ b/fs/xfs/xfs_iops.c
>> @@ -237,7 +237,7 @@ xfs_vn_create(
>> umode_t mode,
>> bool flags)
>> {
>> - return xfs_vn_mknod(dir, dentry, mode, 0);
>> + return xfs_generic_create(dir, dentry, mode, 0, false);
>> }
>>
>> STATIC int
>> @@ -246,7 +246,7 @@ xfs_vn_mkdir(
>> struct dentry *dentry,
>> umode_t mode)
>> {
>> - return xfs_vn_mknod(dir, dentry, mode|S_IFDIR, 0);
>> + return xfs_generic_create(dir, dentry, mode|S_IFDIR, 0, false);
>
> Might as well separate mode, the pipe, and S_IFDIR with a space...
Yeah, will fix it in the next version.
Thanks,
Kaixu
>
> --D
>
>> }
>>
>> STATIC struct dentry *
>> --
>> 2.20.0
>>
--
kaixuxia
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-25 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-24 14:30 [RFC PATCH] xfs: directly call xfs_generic_create() for ->create() and ->mkdir() xiakaixu1987
2020-09-24 15:08 ` Darrick J. Wong
2020-09-25 2:31 ` kaixuxia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox