From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] xfs: temporary transaction subsystem freeze hack
Date: Wed, 30 Sep 2020 09:30:56 -0400 [thread overview]
Message-ID: <20200930133056.GB2649@bfoster> (raw)
In-Reply-To: <20200929205011.GJ14422@dread.disaster.area>
On Wed, Sep 30, 2020 at 06:50:11AM +1000, Dave Chinner wrote:
> On Tue, Sep 29, 2020 at 10:12:27AM -0400, Brian Foster wrote:
> > Implement a quick hack to abuse the superblock freeze mechanism to
> > freeze the XFS transaction subsystem.
> >
> > XXX: to be replaced
>
> What was wrong with the per-cpu counter that I used in the prototype
> I sent? Why re-invent the wheel?
>
We discussed this in the original thread. See [1] (the tail end of my
mail is where we switch from general relogging discussion to the
quotaoff prototype) and your immediate reply for reference. The synopsis
is that I think a percpu rwsem around transaction allocation (what I've
replaced this patch with) is far more straightforward to audit, test and
maintain than annotating quota modifying transactions purely for the
purpose of quotaoff.
> Also, can we call this a pause/resume operation so it doesn't get
> confused with filesystem freezing? Freezing as operation name is way
> too overloaded already...
>
Sure, pause/resume seems fine to me.
Brian
[1] https://lore.kernel.org/linux-xfs/20200702185209.GA58137@bfoster/
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
next prev parent reply other threads:[~2020-09-30 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 14:12 [PATCH RFC 0/3] xfs: rework quotaoff to avoid log deadlock Brian Foster
2020-09-29 14:12 ` [PATCH RFC 1/3] xfs: skip dquot reservations if quota is inactive Brian Foster
2020-09-29 14:12 ` [PATCH RFC 2/3] xfs: temporary transaction subsystem freeze hack Brian Foster
2020-09-29 20:50 ` Dave Chinner
2020-09-30 13:30 ` Brian Foster [this message]
2020-09-29 14:12 ` [PATCH RFC 3/3] xfs: rework quotaoff logging to avoid log deadlock on active fs Brian Foster
2020-09-29 20:48 ` Dave Chinner
2020-09-30 13:30 ` Brian Foster
2020-09-30 16:53 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930133056.GB2649@bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox