From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/3] xfs: rework quotaoff to avoid log deadlock
Date: Thu, 1 Oct 2020 11:03:07 -0400 [thread overview]
Message-ID: <20201001150310.141467-1-bfoster@redhat.com> (raw)
Hi all,
Here's a proper v1 of the quotaoff logging rework. Changes from the RFC
are fairly straightforward and listed below. The one outstanding bit of
feedback from the RFC is the lock / memory ordering question around the
quota flags update. My understanding is that the percpu rwsem provides
the required consistency through a combination of explicit memory
barriers and RCU, so I opted to drop the unnecessary wrapper functions
to make the locking more clear (along with comment updates) and also
eliminate freeze/unfreeze naming confusion.
Thoughts, reviews, flames appreciated.
Brian
v1:
- Replace patch 2 with a proper internal quiesce mechanism.
- Remove unnecessary freeze/unfreeze helpers.
- Relocate quotaoff end transaction to commit inside quiesce window.
- Clean up comments and document new algorithm.
rfc: https://lore.kernel.org/linux-xfs/20200929141228.108688-1-bfoster@redhat.com/
Brian Foster (3):
xfs: skip dquot reservations if quota is inactive
xfs: transaction subsystem quiesce mechanism
xfs: rework quotaoff logging to avoid log deadlock on active fs
fs/xfs/xfs_aops.c | 2 +
fs/xfs/xfs_mount.h | 3 +
fs/xfs/xfs_qm_syscalls.c | 133 +++++++++++++++++++--------------------
fs/xfs/xfs_super.c | 8 +++
fs/xfs/xfs_trans.c | 4 +-
fs/xfs/xfs_trans.h | 20 ++++++
fs/xfs/xfs_trans_dquot.c | 22 +++----
7 files changed, 111 insertions(+), 81 deletions(-)
--
2.25.4
next reply other threads:[~2020-10-01 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 15:03 Brian Foster [this message]
2020-10-01 15:03 ` [PATCH 1/3] xfs: skip dquot reservations if quota is inactive Brian Foster
2020-10-07 22:09 ` Darrick J. Wong
2020-10-01 15:03 ` [PATCH 2/3] xfs: transaction subsystem quiesce mechanism Brian Foster
2020-10-07 22:13 ` Darrick J. Wong
2020-10-08 11:26 ` Brian Foster
2020-10-08 18:27 ` Brian Foster
2020-10-01 15:03 ` [PATCH 3/3] xfs: rework quotaoff logging to avoid log deadlock on active fs Brian Foster
2020-10-07 22:24 ` Darrick J. Wong
2020-10-08 11:29 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001150310.141467-1-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).