From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v2 2/4] xfs: fix the indent in xfs_trans_mod_dquot
Date: Mon, 5 Oct 2020 21:36:09 -0700 [thread overview]
Message-ID: <20201006043609.GU49547@magnolia> (raw)
In-Reply-To: <1601126073-32453-3-git-send-email-kaixuxia@tencent.com>
On Sat, Sep 26, 2020 at 09:14:31PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The formatting is strange in xfs_trans_mod_dquot, so do a reindent.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
"strange". I can just picture the Papyrus font now... :)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_trans_dquot.c | 43 ++++++++++++++--------------------------
> 1 file changed, 15 insertions(+), 28 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index 133fc6fc3edd..fe45b0c3970c 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -221,36 +221,27 @@ xfs_trans_mod_dquot(
> }
>
> switch (field) {
> -
> - /*
> - * regular disk blk reservation
> - */
> - case XFS_TRANS_DQ_RES_BLKS:
> + /* regular disk blk reservation */
> + case XFS_TRANS_DQ_RES_BLKS:
> qtrx->qt_blk_res += delta;
> break;
>
> - /*
> - * inode reservation
> - */
> - case XFS_TRANS_DQ_RES_INOS:
> + /* inode reservation */
> + case XFS_TRANS_DQ_RES_INOS:
> qtrx->qt_ino_res += delta;
> break;
>
> - /*
> - * disk blocks used.
> - */
> - case XFS_TRANS_DQ_BCOUNT:
> + /* disk blocks used. */
> + case XFS_TRANS_DQ_BCOUNT:
> qtrx->qt_bcount_delta += delta;
> break;
>
> - case XFS_TRANS_DQ_DELBCOUNT:
> + case XFS_TRANS_DQ_DELBCOUNT:
> qtrx->qt_delbcnt_delta += delta;
> break;
>
> - /*
> - * Inode Count
> - */
> - case XFS_TRANS_DQ_ICOUNT:
> + /* Inode Count */
> + case XFS_TRANS_DQ_ICOUNT:
> if (qtrx->qt_ino_res && delta > 0) {
> qtrx->qt_ino_res_used += delta;
> ASSERT(qtrx->qt_ino_res >= qtrx->qt_ino_res_used);
> @@ -258,17 +249,13 @@ xfs_trans_mod_dquot(
> qtrx->qt_icount_delta += delta;
> break;
>
> - /*
> - * rtblk reservation
> - */
> - case XFS_TRANS_DQ_RES_RTBLKS:
> + /* rtblk reservation */
> + case XFS_TRANS_DQ_RES_RTBLKS:
> qtrx->qt_rtblk_res += delta;
> break;
>
> - /*
> - * rtblk count
> - */
> - case XFS_TRANS_DQ_RTBCOUNT:
> + /* rtblk count */
> + case XFS_TRANS_DQ_RTBCOUNT:
> if (qtrx->qt_rtblk_res && delta > 0) {
> qtrx->qt_rtblk_res_used += delta;
> ASSERT(qtrx->qt_rtblk_res >= qtrx->qt_rtblk_res_used);
> @@ -276,11 +263,11 @@ xfs_trans_mod_dquot(
> qtrx->qt_rtbcount_delta += delta;
> break;
>
> - case XFS_TRANS_DQ_DELRTBCOUNT:
> + case XFS_TRANS_DQ_DELRTBCOUNT:
> qtrx->qt_delrtb_delta += delta;
> break;
>
> - default:
> + default:
> ASSERT(0);
> }
>
> --
> 2.20.0
>
next prev parent reply other threads:[~2020-10-06 4:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 13:14 [PATCH v2 0/4] xfs: random fixes for disk quota xiakaixu1987
2020-09-26 13:14 ` [PATCH v2 1/4] xfs: do the ASSERT for the arguments O_{u,g,p}dqpp xiakaixu1987
2020-10-06 4:35 ` Darrick J. Wong
2020-09-26 13:14 ` [PATCH v2 2/4] xfs: fix the indent in xfs_trans_mod_dquot xiakaixu1987
2020-10-06 4:36 ` Darrick J. Wong [this message]
2020-09-26 13:14 ` [PATCH v2 3/4] xfs: check tp->t_dqinfo value instead of the XFS_TRANS_DQ_DIRTY flag xiakaixu1987
2020-09-26 15:36 ` Eric Sandeen
2020-10-02 3:31 ` kaixuxia
2020-10-06 4:42 ` Darrick J. Wong
2020-10-06 11:33 ` kaixuxia
2020-09-26 13:14 ` [PATCH v2 4/4] xfs: directly return if the delta equal to zero xiakaixu1987
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006043609.GU49547@magnolia \
--to=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox