Re: [PATCH 1/2] xfsdump: remove obsolete code for handling mountpoint inodes

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Wed, Oct 07, 2020 at 12:07:03AM +0200, Anthony Iliopoulos wrote:
> The S_IFMNT file type was never supported in Linux, remove the last
> vestiges.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>

Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  doc/xfsdump.html | 5 ++---
>  dump/content.c   | 3 ---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/xfsdump.html b/doc/xfsdump.html
> index d4d157fa62c5..9d06129a5e1d 100644
> --- a/doc/xfsdump.html
> +++ b/doc/xfsdump.html
> @@ -102,9 +102,8 @@ or stdout. The dump includes all the filesystem objects of:
>  <li>named pipes (S_FIFO)
>  <li>XENIX named pipes (S_IFNAM) 
>  </ul>
> -but not mount point types (S_IFMNT).
> -It also does not dump files from <i>/var/xfsdump</i> which
> -is where the xfsdump inventory is located.
> +It does not dump files from <i>/var/xfsdump</i> which is where the
> +xfsdump inventory is located.
>  Other data which is stored:
>  <ul>
>  <li> file attributes (stored in stat data) of owner, group, permissions,
> diff --git a/dump/content.c b/dump/content.c
> index 30232d422206..7637fe89609e 100644
> --- a/dump/content.c
> +++ b/dump/content.c
> @@ -3913,9 +3913,6 @@ dump_file(void *arg1,
>  			contextp->cc_stat_lastino = statp->bs_ino;
>  		}
>  		return RV_OK;
> -	/* not yet implemented
> -	case S_IFMNT:
> -	 */
>  	}
>  
>  	if (rv == RV_OK
> -- 
> 2.28.0
>