From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v3 3/5] xfs: delete duplicated tp->t_dqinfo null check and allocation
Date: Wed, 7 Oct 2020 15:01:57 -0700 [thread overview]
Message-ID: <20201007220157.GB6540@magnolia> (raw)
In-Reply-To: <1602082272-20242-4-git-send-email-kaixuxia@tencent.com>
On Wed, Oct 07, 2020 at 10:51:10PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The function xfs_trans_mod_dquot_byino() wrap around xfs_trans_mod_dquot()
> to account for quotas, both of them do the null check and allocation. Thus
> we can delete the duplicated operation in xfs_trans_mod_dquot_byino().
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_trans_dquot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index fe45b0c3970c..1b56065c9ff1 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -143,9 +143,6 @@ xfs_trans_mod_dquot_byino(
> xfs_is_quota_inode(&mp->m_sb, ip->i_ino))
> return;
>
> - if (tp->t_dqinfo == NULL)
> - xfs_trans_alloc_dqinfo(tp);
> -
> if (XFS_IS_UQUOTA_ON(mp) && ip->i_udquot)
> (void) xfs_trans_mod_dquot(tp, ip->i_udquot, field, delta);
> if (XFS_IS_GQUOTA_ON(mp) && ip->i_gdquot)
> --
> 2.20.0
>
next prev parent reply other threads:[~2020-10-07 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 14:51 [PATCH v3 0/5] xfs: random fixes for disk quota xiakaixu1987
2020-10-07 14:51 ` [PATCH v3 1/5] xfs: do the ASSERT for the arguments O_{u,g,p}dqpp xiakaixu1987
2020-10-07 14:51 ` [PATCH v3 2/5] xfs: fix the indent in xfs_trans_mod_dquot xiakaixu1987
2020-10-07 14:51 ` [PATCH v3 3/5] xfs: delete duplicated tp->t_dqinfo null check and allocation xiakaixu1987
2020-10-07 22:01 ` Darrick J. Wong [this message]
2020-10-07 14:51 ` [PATCH v3 4/5] xfs: check tp->t_dqinfo value instead of the XFS_TRANS_DQ_DIRTY flag xiakaixu1987
2020-10-07 22:04 ` Darrick J. Wong
2020-10-08 0:54 ` kaixuxia
2020-10-07 14:51 ` [PATCH v3 5/5] xfs: directly return if the delta equal to zero xiakaixu1987
2020-10-07 22:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007220157.GB6540@magnolia \
--to=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).