From: Gao Xiang <hsiangkao@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>,
Dave Chinner <david@fromorbit.com>,
Gao Xiang <hsiangkao@redhat.com>
Subject: [PATCH v5 0/3] xfsprogs: consolidate stripe validation
Date: Fri, 9 Oct 2020 13:24:18 +0800 [thread overview]
Message-ID: <20201009052421.3328-1-hsiangkao@redhat.com> (raw)
v4: https://lore.kernel.org/r/20201007140402.14295-1-hsiangkao@aol.com
Hi,
This is another approach suggested by Eric in the reply of v3
(if I understand correctly), which also attempts to use
i18n-enabled xfsprogs xfs_notice() to error out sanity check
failure suggested by Dave on IRC.
kernel side of [PATCH 2/3]
https://lore.kernel.org/r/20201009050546.32174-1-hsiangkao@redhat.com
Thanks,
Gao Xiang
Changes since v4:
- [2/3] stretch columns for commit message (Darrick);
- [2/3] add a comment to hasdalign check (Darrick);
- [2/3] break old sunit / swidth != 0 check into two
seperate checks (Darrick);
- [2/3] update an error message description (Darrick);
- [2/3] use bytes for sunit / swidth representation,
so users can see values in the unique unit.
- [3/3] introduce a userspace wrapper
libxfs_validate_stripe_factors (Darrick).
Gao Xiang (3):
libxfs: allow i18n to xfs printk
xfs: introduce xfs_validate_stripe_factors()
mkfs: make use of xfs_validate_stripe_factors()
libxfs/libxfs_api_defs.h | 1 +
libxfs/libxfs_priv.h | 8 ++---
libxfs/xfs_sb.c | 65 +++++++++++++++++++++++++++++++++-------
libxfs/xfs_sb.h | 3 ++
mkfs/xfs_mkfs.c | 23 +++++---------
5 files changed, 69 insertions(+), 31 deletions(-)
--
2.18.1
next reply other threads:[~2020-10-09 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 5:24 Gao Xiang [this message]
2020-10-09 5:24 ` [PATCH v5 1/3] libxfs: allow i18n to xfs printk Gao Xiang
2020-10-09 5:24 ` [PATCH v5 2/3] xfs: introduce xfs_validate_stripe_factors() Gao Xiang
2020-10-09 5:24 ` [PATCH v5 3/3] mkfs: make use of xfs_validate_stripe_factors() Gao Xiang
2020-10-12 13:06 ` Brian Foster
2020-10-12 14:07 ` Gao Xiang
2020-10-12 14:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009052421.3328-1-hsiangkao@redhat.com \
--to=hsiangkao@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).